Function resizeImage
has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring. Open
public function resizeImage()
{
// check file extension
switch ($this->imageMimetype) {
case 'image/png':
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method resizeImage
has 53 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function resizeImage()
{
// check file extension
switch ($this->imageMimetype) {
case 'image/png':
Method mergeImage
has 52 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function mergeImage(): void
{
$dest = \imagecreatefromjpeg($this->endFile);
$src = \imagecreatefromjpeg($this->sourceFile);
if (4 == $this->mergeType) {
Method resizeAndCrop
has 50 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function resizeAndCrop()
{
// check file extension
switch ($this->imageMimetype) {
case 'image/png':
Function mergeImage
has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring. Open
public function mergeImage(): void
{
$dest = \imagecreatefromjpeg($this->endFile);
$src = \imagecreatefromjpeg($this->sourceFile);
if (4 == $this->mergeType) {
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function resizeAndCrop
has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring. Open
public function resizeAndCrop()
{
// check file extension
switch ($this->imageMimetype) {
case 'image/png':
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Avoid too many return
statements within this method. Open
return true;
Avoid too many return
statements within this method. Open
return false;
The method resizeAndCrop() has an NPath complexity of 512. The configured NPath complexity threshold is 200. Open
public function resizeAndCrop()
{
// check file extension
switch ($this->imageMimetype) {
case 'image/png':
- Read upRead up
- Exclude checks
NPathComplexity
Since: 0.1
The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.
Example
class Foo {
function bar() {
// lots of complicated code
}
}
Source https://phpmd.org/rules/codesize.html#npathcomplexity
The method resizeImage() has a Cyclomatic Complexity of 12. The configured cyclomatic complexity threshold is 10. Open
public function resizeImage()
{
// check file extension
switch ($this->imageMimetype) {
case 'image/png':
- Read upRead up
- Exclude checks
CyclomaticComplexity
Since: 0.1
Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.
Example
// Cyclomatic Complexity = 11
class Foo {
1 public function example() {
2 if ($a == $b) {
3 if ($a1 == $b1) {
fiddle();
4 } elseif ($a2 == $b2) {
fiddle();
} else {
fiddle();
}
5 } elseif ($c == $d) {
6 while ($c == $d) {
fiddle();
}
7 } elseif ($e == $f) {
8 for ($n = 0; $n < $h; $n++) {
fiddle();
}
} else {
switch ($z) {
9 case 1:
fiddle();
break;
10 case 2:
fiddle();
break;
11 case 3:
fiddle();
break;
default:
fiddle();
break;
}
}
}
}
Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity
The method mergeImage() has a Cyclomatic Complexity of 13. The configured cyclomatic complexity threshold is 10. Open
public function mergeImage(): void
{
$dest = \imagecreatefromjpeg($this->endFile);
$src = \imagecreatefromjpeg($this->sourceFile);
if (4 == $this->mergeType) {
- Read upRead up
- Exclude checks
CyclomaticComplexity
Since: 0.1
Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.
Example
// Cyclomatic Complexity = 11
class Foo {
1 public function example() {
2 if ($a == $b) {
3 if ($a1 == $b1) {
fiddle();
4 } elseif ($a2 == $b2) {
fiddle();
} else {
fiddle();
}
5 } elseif ($c == $d) {
6 while ($c == $d) {
fiddle();
}
7 } elseif ($e == $f) {
8 for ($n = 0; $n < $h; $n++) {
fiddle();
}
} else {
switch ($z) {
9 case 1:
fiddle();
break;
10 case 2:
fiddle();
break;
11 case 3:
fiddle();
break;
default:
fiddle();
break;
}
}
}
}
Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity
The method resizeAndCrop() has a Cyclomatic Complexity of 11. The configured cyclomatic complexity threshold is 10. Open
public function resizeAndCrop()
{
// check file extension
switch ($this->imageMimetype) {
case 'image/png':
- Read upRead up
- Exclude checks
CyclomaticComplexity
Since: 0.1
Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.
Example
// Cyclomatic Complexity = 11
class Foo {
1 public function example() {
2 if ($a == $b) {
3 if ($a1 == $b1) {
fiddle();
4 } elseif ($a2 == $b2) {
fiddle();
} else {
fiddle();
}
5 } elseif ($c == $d) {
6 while ($c == $d) {
fiddle();
}
7 } elseif ($e == $f) {
8 for ($n = 0; $n < $h; $n++) {
fiddle();
}
} else {
switch ($z) {
9 case 1:
fiddle();
break;
10 case 2:
fiddle();
break;
11 case 3:
fiddle();
break;
default:
fiddle();
break;
}
}
}
}
Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity
The method resizeImage uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
} else {
$newWidth = $this->maxWidth;
$divisor = $width / $newWidth;
$newHeight = \floor($height / $divisor);
}
- Read upRead up
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}
Source https://phpmd.org/rules/cleancode.html#elseexpression
The method resizeImage uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
} else {
$newHeight = $this->maxHeight;
$divisor = $height / $newHeight;
$newWidth = \floor($width / $divisor);
}
- Read upRead up
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}
Source https://phpmd.org/rules/cleancode.html#elseexpression
The method resizeAndCrop uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
} else {
$max_height_offset = (int)\round(($maxHeightResize - $this->maxHeight) / 2);
}
- Read upRead up
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}
Source https://phpmd.org/rules/cleancode.html#elseexpression
The method resizeAndCrop uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
} else {
$max_width_ratio = $this->maxWidth / $original_w;
$maxHeightResize = (int)\round($original_h * $max_width_ratio);
}
- Read upRead up
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}
Source https://phpmd.org/rules/cleancode.html#elseexpression
The method resizeImage uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
} else {
return 'copy';
}
- Read upRead up
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}
Source https://phpmd.org/rules/cleancode.html#elseexpression
The variable $original_w is not named in camelCase. Open
public function resizeAndCrop()
{
// check file extension
switch ($this->imageMimetype) {
case 'image/png':
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $max_width_offset is not named in camelCase. Open
public function resizeAndCrop()
{
// check file extension
switch ($this->imageMimetype) {
case 'image/png':
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $max_width_resize is not named in camelCase. Open
public function resizeAndCrop()
{
// check file extension
switch ($this->imageMimetype) {
case 'image/png':
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $max_width_ratio is not named in camelCase. Open
public function resizeAndCrop()
{
// check file extension
switch ($this->imageMimetype) {
case 'image/png':
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $max_width_resize is not named in camelCase. Open
public function resizeAndCrop()
{
// check file extension
switch ($this->imageMimetype) {
case 'image/png':
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $original_w is not named in camelCase. Open
public function resizeAndCrop()
{
// check file extension
switch ($this->imageMimetype) {
case 'image/png':
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $original_w is not named in camelCase. Open
public function resizeAndCrop()
{
// check file extension
switch ($this->imageMimetype) {
case 'image/png':
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $max_width_resize is not named in camelCase. Open
public function resizeAndCrop()
{
// check file extension
switch ($this->imageMimetype) {
case 'image/png':
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $original_w is not named in camelCase. Open
public function resizeAndCrop()
{
// check file extension
switch ($this->imageMimetype) {
case 'image/png':
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $max_height_ratio is not named in camelCase. Open
public function resizeAndCrop()
{
// check file extension
switch ($this->imageMimetype) {
case 'image/png':
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $original_h is not named in camelCase. Open
public function resizeAndCrop()
{
// check file extension
switch ($this->imageMimetype) {
case 'image/png':
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $max_width_resize is not named in camelCase. Open
public function resizeAndCrop()
{
// check file extension
switch ($this->imageMimetype) {
case 'image/png':
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $max_height_ratio is not named in camelCase. Open
public function resizeAndCrop()
{
// check file extension
switch ($this->imageMimetype) {
case 'image/png':
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $original_h is not named in camelCase. Open
public function resizeAndCrop()
{
// check file extension
switch ($this->imageMimetype) {
case 'image/png':
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $max_width_ratio is not named in camelCase. Open
public function resizeAndCrop()
{
// check file extension
switch ($this->imageMimetype) {
case 'image/png':
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $max_height_ratio is not named in camelCase. Open
public function resizeAndCrop()
{
// check file extension
switch ($this->imageMimetype) {
case 'image/png':
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $original_h is not named in camelCase. Open
public function resizeAndCrop()
{
// check file extension
switch ($this->imageMimetype) {
case 'image/png':
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $max_width_resize is not named in camelCase. Open
public function resizeAndCrop()
{
// check file extension
switch ($this->imageMimetype) {
case 'image/png':
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $max_width_resize is not named in camelCase. Open
public function resizeAndCrop()
{
// check file extension
switch ($this->imageMimetype) {
case 'image/png':
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $max_width_resize is not named in camelCase. Open
public function resizeAndCrop()
{
// check file extension
switch ($this->imageMimetype) {
case 'image/png':
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $max_width_resize is not named in camelCase. Open
public function resizeAndCrop()
{
// check file extension
switch ($this->imageMimetype) {
case 'image/png':
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $max_height_offset is not named in camelCase. Open
public function resizeAndCrop()
{
// check file extension
switch ($this->imageMimetype) {
case 'image/png':
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $original_w is not named in camelCase. Open
public function resizeAndCrop()
{
// check file extension
switch ($this->imageMimetype) {
case 'image/png':
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $max_width_resize is not named in camelCase. Open
public function resizeAndCrop()
{
// check file extension
switch ($this->imageMimetype) {
case 'image/png':
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $max_width_offset is not named in camelCase. Open
public function resizeAndCrop()
{
// check file extension
switch ($this->imageMimetype) {
case 'image/png':
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $max_height_offset is not named in camelCase. Open
public function resizeAndCrop()
{
// check file extension
switch ($this->imageMimetype) {
case 'image/png':
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $original_h is not named in camelCase. Open
public function resizeAndCrop()
{
// check file extension
switch ($this->imageMimetype) {
case 'image/png':
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $max_width_offset is not named in camelCase. Open
public function resizeAndCrop()
{
// check file extension
switch ($this->imageMimetype) {
case 'image/png':
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $original_h is not named in camelCase. Open
public function resizeAndCrop()
{
// check file extension
switch ($this->imageMimetype) {
case 'image/png':
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $max_height_offset is not named in camelCase. Open
public function resizeAndCrop()
{
// check file extension
switch ($this->imageMimetype) {
case 'image/png':
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $max_height_ratio is not named in camelCase. Open
public function resizeAndCrop()
{
// check file extension
switch ($this->imageMimetype) {
case 'image/png':
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $max_width_resize is not named in camelCase. Open
public function resizeAndCrop()
{
// check file extension
switch ($this->imageMimetype) {
case 'image/png':
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}