mambax7/publisher

View on GitHub
class/ThemeTabForm.php

Summary

Maintainability
C
1 day
Test Coverage

__construct accesses the super-global variable $GLOBALS.
Open

    public function __construct($title, $name, $action, $method = 'post', $addtoken = false, $summary = '')
    {
        //        global $xoTheme;
        //        $GLOBALS['xoTheme']->addScript(PUBLISHER_URL . '/assets/js/ui.core.js');
        //        $GLOBALS['xoTheme']->addScript(PUBLISHER_URL . '/assets/js/ui.tabs.js');
Severity: Minor
Found in class/ThemeTabForm.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

__construct accesses the super-global variable $GLOBALS.
Open

    public function __construct($title, $name, $action, $method = 'post', $addtoken = false, $summary = '')
    {
        //        global $xoTheme;
        //        $GLOBALS['xoTheme']->addScript(PUBLISHER_URL . '/assets/js/ui.core.js');
        //        $GLOBALS['xoTheme']->addScript(PUBLISHER_URL . '/assets/js/ui.tabs.js');
Severity: Minor
Found in class/ThemeTabForm.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

ThemeTabForm has 28 functions (exceeds 20 allowed). Consider refactoring.
Open

class ThemeTabForm extends \XoopsForm
{
    public $formTabs = [];
    /**
     * "action" attribute for the html form
Severity: Minor
Found in class/ThemeTabForm.php - About 3 hrs to fix

    The class ThemeTabForm has 11 public methods. Consider refactoring ThemeTabForm to keep number of public methods under 10.
    Open

    class ThemeTabForm extends \XoopsForm
    {
        public $formTabs = [];
        /**
         * "action" attribute for the html form
    Severity: Minor
    Found in class/ThemeTabForm.php by phpmd

    TooManyPublicMethods

    Since: 0.1

    A class with too many public methods is probably a good suspect for refactoring, in order to reduce its complexity and find a way to have more fine grained objects.

    By default it ignores methods starting with 'get' or 'set'.

    Example

    Source https://phpmd.org/rules/codesize.html#toomanypublicmethods

    The class ThemeTabForm has an overall complexity of 73 which is very high. The configured complexity threshold is 50.
    Open

    class ThemeTabForm extends \XoopsForm
    {
        public $formTabs = [];
        /**
         * "action" attribute for the html form
    Severity: Minor
    Found in class/ThemeTabForm.php by phpmd

    File ThemeTabForm.php has 266 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    <?php
    
    declare(strict_types=1);
    
    namespace XoopsModules\Publisher;
    Severity: Minor
    Found in class/ThemeTabForm.php - About 2 hrs to fix

      Method assign has 49 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function assign(\XoopsTpl $tpl)
          {
              $i        = -1;
              $tab      = -1;
              $elements = [];
      Severity: Minor
      Found in class/ThemeTabForm.php - About 1 hr to fix

        Function assign has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
        Open

            public function assign(\XoopsTpl $tpl)
            {
                $i        = -1;
                $tab      = -1;
                $elements = [];
        Severity: Minor
        Found in class/ThemeTabForm.php - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method __construct has 6 arguments (exceeds 4 allowed). Consider refactoring.
        Open

            public function __construct($title, $name, $action, $method = 'post', $addtoken = false, $summary = '')
        Severity: Minor
        Found in class/ThemeTabForm.php - About 45 mins to fix

          Function addElement has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
          Open

              public function addElement($formElement, $required = false)
              {
                  if (\is_string($formElement)) {
                      $this->elements[] = &$formElement;
                  } elseif (\is_subclass_of($formElement, 'xoopsformelement')) {
          Severity: Minor
          Found in class/ThemeTabForm.php - About 45 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function setElementValues has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
          Open

              public function setElementValues($values)
              {
                  if (\is_array($values) && !empty($values)) {
                      // will not use getElementByName() for performance..
                      $elements = &$this->getElements(true);
          Severity: Minor
          Found in class/ThemeTabForm.php - About 35 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          The method assign() has a Cyclomatic Complexity of 10. The configured cyclomatic complexity threshold is 10.
          Open

              public function assign(\XoopsTpl $tpl)
              {
                  $i        = -1;
                  $tab      = -1;
                  $elements = [];
          Severity: Minor
          Found in class/ThemeTabForm.php by phpmd

          CyclomaticComplexity

          Since: 0.1

          Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

          Example

          // Cyclomatic Complexity = 11
          class Foo {
          1   public function example() {
          2       if ($a == $b) {
          3           if ($a1 == $b1) {
                          fiddle();
          4           } elseif ($a2 == $b2) {
                          fiddle();
                      } else {
                          fiddle();
                      }
          5       } elseif ($c == $d) {
          6           while ($c == $d) {
                          fiddle();
                      }
          7        } elseif ($e == $f) {
          8           for ($n = 0; $n < $h; $n++) {
                          fiddle();
                      }
                  } else {
                      switch ($z) {
          9               case 1:
                              fiddle();
                              break;
          10              case 2:
                              fiddle();
                              break;
          11              case 3:
                              fiddle();
                              break;
                          default:
                              fiddle();
                              break;
                      }
                  }
              }
          }

          Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

          The method getTitle has a boolean flag argument $encode, which is a certain sign of a Single Responsibility Principle violation.
          Open

              public function getTitle($encode = false)
          Severity: Minor
          Found in class/ThemeTabForm.php by phpmd

          BooleanArgumentFlag

          Since: 1.4.0

          A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

          Example

          class Foo {
              public function bar($flag = true) {
              }
          }

          Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

          The method addElement has a boolean flag argument $required, which is a certain sign of a Single Responsibility Principle violation.
          Open

              public function addElement($formElement, $required = false)
          Severity: Minor
          Found in class/ThemeTabForm.php by phpmd

          BooleanArgumentFlag

          Since: 1.4.0

          A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

          Example

          class Foo {
              public function bar($flag = true) {
              }
          }

          Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

          The method getElementValue has a boolean flag argument $encode, which is a certain sign of a Single Responsibility Principle violation.
          Open

              public function getElementValue($name, $encode = false)
          Severity: Minor
          Found in class/ThemeTabForm.php by phpmd

          BooleanArgumentFlag

          Since: 1.4.0

          A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

          Example

          class Foo {
              public function bar($flag = true) {
              }
          }

          Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

          The method __construct has a boolean flag argument $addtoken, which is a certain sign of a Single Responsibility Principle violation.
          Open

              public function __construct($title, $name, $action, $method = 'post', $addtoken = false, $summary = '')
          Severity: Minor
          Found in class/ThemeTabForm.php by phpmd

          BooleanArgumentFlag

          Since: 1.4.0

          A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

          Example

          class Foo {
              public function bar($flag = true) {
              }
          }

          Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

          The method getElements has a boolean flag argument $recurse, which is a certain sign of a Single Responsibility Principle violation.
          Open

              public function &getElements($recurse = false)
          Severity: Minor
          Found in class/ThemeTabForm.php by phpmd

          BooleanArgumentFlag

          Since: 1.4.0

          A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

          Example

          class Foo {
              public function bar($flag = true) {
              }
          }

          Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

          Missing class import via use statement (line '109', column '35').
          Open

                      $this->addElement(new \XoopsFormHiddenToken());
          Severity: Minor
          Found in class/ThemeTabForm.php by phpmd

          MissingImport

          Since: 2.7.0

          Importing all external classes in a file through use statements makes them clearly visible.

          Example

          function make() {
              return new \stdClass();
          }

          Source http://phpmd.org/rules/cleancode.html#MissingImport

          The method renderValidationJS has a boolean flag argument $withtags, which is a certain sign of a Single Responsibility Principle violation.
          Open

              public function renderValidationJS($withtags = true)
          Severity: Minor
          Found in class/ThemeTabForm.php by phpmd

          BooleanArgumentFlag

          Since: 1.4.0

          A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

          Example

          class Foo {
              public function bar($flag = true) {
              }
          }

          Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

          The method getSummary has a boolean flag argument $encode, which is a certain sign of a Single Responsibility Principle violation.
          Open

              public function getSummary($encode = false)
          Severity: Minor
          Found in class/ThemeTabForm.php by phpmd

          BooleanArgumentFlag

          Since: 1.4.0

          A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

          Example

          class Foo {
              public function bar($flag = true) {
              }
          }

          Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

          The method getAction has a boolean flag argument $encode, which is a certain sign of a Single Responsibility Principle violation.
          Open

              public function getAction($encode = true)
          Severity: Minor
          Found in class/ThemeTabForm.php by phpmd

          BooleanArgumentFlag

          Since: 1.4.0

          A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

          Example

          class Foo {
              public function bar($flag = true) {
              }
          }

          Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

          The method getElementValues has a boolean flag argument $encode, which is a certain sign of a Single Responsibility Principle violation.
          Open

              public function getElementValues($encode = false)
          Severity: Minor
          Found in class/ThemeTabForm.php by phpmd

          BooleanArgumentFlag

          Since: 1.4.0

          A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

          Example

          class Foo {
              public function bar($flag = true) {
              }
          }

          Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

          The method getName has a boolean flag argument $encode, which is a certain sign of a Single Responsibility Principle violation.
          Open

              public function getName($encode = true)
          Severity: Minor
          Found in class/ThemeTabForm.php by phpmd

          BooleanArgumentFlag

          Since: 1.4.0

          A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

          Example

          class Foo {
              public function bar($flag = true) {
              }
          }

          Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

          The method addElement uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
          Open

                          } else {
                              $formElement->required = true;
                          }
          Severity: Minor
          Found in class/ThemeTabForm.php by phpmd

          ElseExpression

          Since: 1.4.0

          An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

          Example

          class Foo
          {
              public function bar($flag)
              {
                  if ($flag) {
                      // one branch
                  } else {
                      // another branch
                  }
              }
          }

          Source https://phpmd.org/rules/cleancode.html#elseexpression

          Avoid unused parameters such as '$extra'.
          Open

              public function insertBreak($extra = null)
          Severity: Minor
          Found in class/ThemeTabForm.php by phpmd

          UnusedFormalParameter

          Since: 0.2

          Avoid passing parameters to methods or constructors and then not using those parameters.

          Example

          class Foo
          {
              private function bar($howdy)
              {
                  // $howdy is not used
              }
          }

          Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

          Avoid unused local variables such as '$iValue'.
          Open

                  foreach ($this->elements as $i => $iValue) {
          Severity: Minor
          Found in class/ThemeTabForm.php by phpmd

          UnusedLocalVariable

          Since: 0.2

          Detects when a local variable is declared and/or assigned, but not used.

          Example

          class Foo {
              public function doSomething()
              {
                  $i = 5; // Unused
              }
          }

          Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable

          Avoid variables with short names like $i. Configured minimum length is 3.
          Open

                  $i        = -1;
          Severity: Minor
          Found in class/ThemeTabForm.php by phpmd

          ShortVariable

          Since: 0.2

          Detects when a field, local, or parameter has a very short name.

          Example

          class Something {
              private $q = 15; // VIOLATION - Field
              public static function main( array $as ) { // VIOLATION - Formal
                  $r = 20 + $this->q; // VIOLATION - Local
                  for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
                      $r += $this->q;
                  }
              }
          }

          Source https://phpmd.org/rules/naming.html#shortvariable

          Avoid variables with short names like $n. Configured minimum length is 3.
          Open

                      $n                        = $eleName ?: $i;
          Severity: Minor
          Found in class/ThemeTabForm.php by phpmd

          ShortVariable

          Since: 0.2

          Detects when a field, local, or parameter has a very short name.

          Example

          class Something {
              private $q = 15; // VIOLATION - Field
              public static function main( array $as ) { // VIOLATION - Formal
                  $r = 20 + $this->q; // VIOLATION - Local
                  for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
                      $r += $this->q;
                  }
              }
          }

          Source https://phpmd.org/rules/naming.html#shortvariable

          Avoid variables with short names like $js. Configured minimum length is 3.
          Open

                  $js = $this->renderValidationJS();
          Severity: Minor
          Found in class/ThemeTabForm.php by phpmd

          ShortVariable

          Since: 0.2

          Detects when a field, local, or parameter has a very short name.

          Example

          class Something {
              private $q = 15; // VIOLATION - Field
              public static function main( array $as ) { // VIOLATION - Formal
                  $r = 20 + $this->q; // VIOLATION - Local
                  for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
                      $r += $this->q;
                  }
              }
          }

          Source https://phpmd.org/rules/naming.html#shortvariable

          Avoid variables with short names like $js. Configured minimum length is 3.
          Open

                  $js = '';
          Severity: Minor
          Found in class/ThemeTabForm.php by phpmd

          ShortVariable

          Since: 0.2

          Detects when a field, local, or parameter has a very short name.

          Example

          class Something {
              private $q = 15; // VIOLATION - Field
              public static function main( array $as ) { // VIOLATION - Formal
                  $r = 20 + $this->q; // VIOLATION - Local
                  for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
                      $r += $this->q;
                  }
              }
          }

          Source https://phpmd.org/rules/naming.html#shortvariable

          A file should declare new symbols (classes, functions, constants, etc.) and cause no other side effects, or it should execute logic with side effects, but should not do both. The first symbol is defined on line 33 and the first side effect is on line 25.
          Open

          <?php
          Severity: Minor
          Found in class/ThemeTabForm.php by phpcodesniffer

          There are no issues that match your filters.

          Category
          Status