Sign upLogin

mambax7/publisher

View on GitHub
Star
file.php

Summary

Maintainability
A
1 hr
Test Coverage

Avoid deeply nested control flow statements.
Open

                    if ($fileObj->storeUpload('item_upload_file', $allowedMimetypes, $errors)) {
                        unlink($oldfile);
                    }
Severity: Major
Found in file.php - About 45 mins to fix

    TODO found
    Open

                // TODO : display the available mimetypes to the user
    Severity: Minor
    Found in file.php by fixme

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

            if ($confirm) {
            if (!$helper->getHandler('File')
                        ->delete($fileObj)) {
                redirect_header('item.php?itemid=' . $fileObj->itemid(), 2, _AM_PUBLISHER_FILE_DELETE_ERROR);
            }
    Severity: Minor
    Found in file.php and 1 other location - About 1 hr to fix
    submit.php on lines 146..156

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 100.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status