mambax7/publisher

View on GitHub

Showing 3,032 of 3,032 total issues

File ajaxupload.3.9.js has 368 lines of code (exceeds 250 allowed). Consider refactoring.
Open

/**
 * AJAX Upload ( http://valums.com/ajax-upload/ )
 * Copyright (c) Andris Valums
 * Licensed under the MIT license ( http://valums.com/mit-license/ )
 * Thanks to Gary Haran, David Mark, Corey Burns and others for contributions
Severity: Minor
Found in assets/js/ajaxupload.3.9.js - About 4 hrs to fix

    Method publisher_search_show has 119 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    function publisher_search_show($options)
    {
        $block  = [];
        $helper = Helper::getInstance();
        /** @var CategoryHandler $categoryHandler */
    Severity: Major
    Found in blocks/search.php - About 4 hrs to fix

      Function listBlocks has a Cognitive Complexity of 32 (exceeds 5 allowed). Consider refactoring.
      Open

          public function listBlocks(): void
          {
              global $xoopsModule, $pathIcon16;
              require_once XOOPS_ROOT_PATH . '/class/xoopslists.php';
              //        xoops_loadLanguage('admin', 'system');
      Severity: Minor
      Found in class/Common/Blocksadmin.php - About 4 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method add has 118 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public static function add(): void
          {
              $helper = Helper::getInstance();
              /** @var MimetypeHandler $mimetypeHandler */
              $mimetypeHandler = $helper->getHandler('Mimetype');
      Severity: Major
      Found in class/MimetypesUtility.php - About 4 hrs to fix

        Timthumb has 35 functions (exceeds 20 allowed). Consider refactoring.
        Open

        class Timthumb
        {
            protected        $src                      = '';
            protected        $is404                    = false;
            protected        $docRoot                  = '';
        Severity: Minor
        Found in thumb.php - About 4 hrs to fix

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

                      for (var h = 0; h < currentContext.length; h++) {
                          var elements;
                          if (tagName == '*') {
                              elements = getAllChildren(currentContext[h]);
                          } else {
          Severity: Major
          Found in assets/js/behavior.js and 1 other location - About 4 hrs to fix
          assets/js/behavior.js on lines 179..189

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 125.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

                      for (var h = 0; h < currentContext.length; h++) {
                          var elements;
                          if (tagName == '*') {
                              elements = getAllChildren(currentContext[h]);
                          } else {
          Severity: Major
          Found in assets/js/behavior.js and 1 other location - About 4 hrs to fix
          assets/js/behavior.js on lines 147..157

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 125.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Function publisher_items_columns_show has a Cognitive Complexity of 30 (exceeds 5 allowed). Consider refactoring.
          Open

          function publisher_items_columns_show($options)
          {
              //    global $xoTheme;
              $helper = Helper::getInstance();
              /** @var CategoryHandler $categoryHandler */
          Severity: Minor
          Found in blocks/items_columns.php - About 4 hrs to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function smarty_modifier_rewrite_url has a Cognitive Complexity of 30 (exceeds 5 allowed). Consider refactoring.
          Open

          function smarty_modifier_rewrite_url($url, $insert_param, $param_value = null, $remove_params_arr = '')
          {
              //parse $insert_param if it is a query string
              if (preg_match('/.+=([\w%,-])*/', $insert_param)) {
                  parse_str($insert_param, $insert_arr);
          Severity: Minor
          Found in extra/modifier.rewrite_url.php - About 4 hrs to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function createElements has a Cognitive Complexity of 30 (exceeds 5 allowed). Consider refactoring.
          Open

              public function createElements(): void
              {
                  // require_once  \dirname(__DIR__, 2) . '/include/common.php';
                  // Category
                  $criteria = new \Criteria(null);
          Severity: Minor
          Found in class/Form/CategoryForm.php - About 4 hrs to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method editCategory has 108 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public static function editCategory($showmenu = false, $categoryid = 0, $nbSubCats = 4, $categoryObj = null): void
              {
                  $helper       = Helper::getInstance();
                  $configurator = new Common\Configurator();
                  $icons        = $configurator->icons;
          Severity: Major
          Found in class/Utility.php - About 4 hrs to fix

            Function publisher_search_show has a Cognitive Complexity of 28 (exceeds 5 allowed). Consider refactoring.
            Open

            function publisher_search_show($options)
            {
                $block  = [];
                $helper = Helper::getInstance();
                /** @var CategoryHandler $categoryHandler */
            Severity: Minor
            Found in blocks/search.php - About 4 hrs to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method createSchemaFromSqlfile has 99 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                public function createSchemaFromSqlfile(): bool
                {
                    if (!\is_file($this->fileSql)) {
                        \xoops_error('Error: Sql file not found!');
                        return false;
            Severity: Major
            Found in class/Common/MigrateHelper.php - About 3 hrs to fix

              File admin.php has 330 lines of code (exceeds 250 allowed). Consider refactoring.
              Open

              <?php declare(strict_types=1);
              
              /**
               * Module: Publisher
               * Author: The SmartFactory <www.smartfactory.ca>
              Severity: Minor
              Found in language/english/admin.php - About 3 hrs to fix

                Function init has 97 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                            function init() {
                
                                // popeye dom setup
                                //--------------------------------------------------------------
                
                
                Severity: Major
                Found in assets/js/jquery.popeye-2.1.js - About 3 hrs to fix

                  `` has 31 functions (exceeds 20 allowed). Consider refactoring.
                  Open

                      {
                          def: 'easeOutQuad',
                          swing: function (x, t, b, c, d) {
                              //alert(jQuery.easing.default);
                              return jQuery.easing[jQuery.easing.def](x, t, b, c, d);
                  Severity: Minor
                  Found in assets/js/jquery.easing.js - About 3 hrs to fix

                    File VoteHandler.php has 325 lines of code (exceeds 250 allowed). Consider refactoring.
                    Open

                    <?php declare(strict_types=1);
                    
                    namespace XoopsModules\Publisher;
                    
                    /*
                    Severity: Minor
                    Found in class/VoteHandler.php - About 3 hrs to fix

                      Method render has 95 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                          public function render(?array $block = null)
                          {
                              \xoops_load('XoopsFormLoader');
                              \xoops_loadLanguage('common', $this->moduleDirNameUpper);
                      
                      
                      Severity: Major
                      Found in class/Common/Blocksadmin.php - About 3 hrs to fix

                        Method setVarsFromRequest has 95 lines of code (exceeds 25 allowed). Consider refactoring.
                        Open

                            public function setVarsFromRequest(): void
                            {
                                //Required fields
                                //        if (!empty($categoryid = Request::getInt('categoryid', 0, 'POST'))) {
                                //            $this->setVar('categoryid', $categoryid);}
                        Severity: Major
                        Found in class/Item.php - About 3 hrs to fix

                          Function publisher_items_recent_show has a Cognitive Complexity of 26 (exceeds 5 allowed). Consider refactoring.
                          Open

                          function publisher_items_recent_show($options)
                          {
                              $helper = Helper::getInstance();
                              /** @var ItemHandler $itemHandler */
                              $itemHandler = $helper->getHandler('Item');
                          Severity: Minor
                          Found in blocks/items_recent.php - About 3 hrs to fix

                          Cognitive Complexity

                          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                          A method's cognitive complexity is based on a few simple rules:

                          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                          • Code is considered more complex for each "break in the linear flow of the code"
                          • Code is considered more complex when "flow breaking structures are nested"

                          Further reading

                          Severity
                          Category
                          Status
                          Source
                          Language