manishrc/promostandards-sdk-js

View on GitHub

Showing 4 of 108 total issues

File templates.ts has 595 lines of code (exceeds 250 allowed). Consider refactoring.
Open

const pug = require("pug");

// Inventory
// getInventoryLevels()
export const getInventoryLevels: () => string = pug.compile(`
Severity: Major
Found in lib/templates.ts - About 1 day to fix

    Function promoStandardsAPIRequest has 32 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public promoStandardsAPIRequest(
          serviceAndMethodName: string,
          params: any
        ): Promise<any> {
          return new Promise((resolve, reject) => {
    Severity: Minor
    Found in lib/PromoStandards.ts - About 1 hr to fix

      Function replaceArrayTagsWithArrays has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

      export const replaceArrayTagsWithArrays = (obj: any) => {
        let key;
        if (obj instanceof Object) {
          for (key in obj) {
            if (obj.hasOwnProperty(key) && /.*Array/.test(key)) {
      Severity: Minor
      Found in lib/Utils.ts - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function skipLevel has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

      export const skipLevel = (obj: any) => {
        let key: string;
        if (obj instanceof Object) {
          for (key in obj) {
            if (obj.hasOwnProperty(key)) return obj[key];
      Severity: Minor
      Found in lib/Utils.ts - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Severity
      Category
      Status
      Source
      Language