mansona/ember-cli-notifications

View on GitHub

Showing 51 of 51 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

  @action
  handleMouseEnter() {
    if (this.notification.autoClear) {
      set(this, 'paused', true);
      this.notifications.pauseAutoClear(this.notification);
Severity: Major
Found in addon/components/notification-message.js and 1 other location - About 1 hr to fix
addon/components/notification-message.js on lines 86..92

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 55.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

  @action
  handleMouseLeave() {
    if (this.notification.autoClear) {
      set(this, 'paused', false);
      this.notifications.setupAutoClear(this.notification);
Severity: Major
Found in addon/components/notification-message.js and 1 other location - About 1 hr to fix
addon/components/notification-message.js on lines 78..84

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 55.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Rule doesn't have all its properties in alphabetical order.
Open

.ember-cli-notifications-notification__container .c-notification__icon {

Parsing error: parser.parse is not a function
Open

'use strict';
Severity: Minor
Found in testem.js by eslint

For more information visit Source: http://eslint.org/docs/rules/

Parsing error: parser.parse is not a function
Open

'use strict';
Severity: Minor
Found in index.js by eslint

For more information visit Source: http://eslint.org/docs/rules/

Expected RBRACE at line 8, col 3.
Open

  --ecn-icon-color: rgba(255, 255, 255, 0.74);

Expected RBRACE at line 15, col 3.
Open

  --ecn-green: #64ce83;

Expected RBRACE at line 6, col 3.
Open

  --ecn-icon-width: 30px;

Expected RBRACE at line 7, col 3.
Open

  --ecn-icon-position: 10px;

Expected RBRACE at line 11, col 3.
Open

  --ecn-notification-max-height: 800px;

Rule doesn't have all its properties in alphabetical order.
Open

.ember-cli-notifications-notification__container {

Parsing error: parser.parse is not a function
Open

'use strict';
Severity: Minor
Found in ember-cli-build.js by eslint

For more information visit Source: http://eslint.org/docs/rules/

Parsing error: parser.parse is not a function
Open

/* eslint-disable ember/no-classic-components, ember/no-computed-properties-in-native-classes */

For more information visit Source: http://eslint.org/docs/rules/

Expected RBRACE at line 17, col 3.
Open

  --ecn-orange: #ff7f48;

Rule doesn't have all its properties in alphabetical order.
Open

  0% {

Rule doesn't have all its properties in alphabetical order.
Open

  100% {

Parsing error: parser.parse is not a function
Open

'use strict';
Severity: Minor
Found in .template-lintrc.js by eslint

For more information visit Source: http://eslint.org/docs/rules/

Expected RBRACE at line 12, col 3.
Open

  --ecn-notification-border-radius: 3px;

Expected RBRACE at line 9, col 3.
Open

  --ecn-icon-lighten-background: rgba(255, 255, 255, 0.2);

Rule doesn't have all its properties in alphabetical order.
Open

.ember-cli-notifications-notification__container .c-notification {
Severity
Category
Status
Source
Language