marekkirejczyk/ethereum.rb

View on GitHub

Showing 11 of 11 total issues

Method create has a Cognitive Complexity of 51 (exceeds 5 allowed). Consider refactoring.
Open

    def self.create(file: nil, client: Ethereum::Singleton.instance, code: nil, abi: nil, address: nil, name: nil, contract_index: nil, truffle: nil)
      contract = nil
      if file.present?
        contracts = Ethereum::Initializer.new(file, client).build_all
        raise "No contracts compiled" if contracts.empty?
Severity: Minor
Found in lib/ethereum/contract.rb - About 7 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Class Contract has 28 methods (exceeds 20 allowed). Consider refactoring.
Open

  class Contract

    attr_reader :address
    attr_accessor :key
    attr_accessor :gas_limit, :gas_price, :nonce
Severity: Minor
Found in lib/ethereum/contract.rb - About 3 hrs to fix

    Class Formatter has 24 methods (exceeds 20 allowed). Consider refactoring.
    Open

      class Formatter
    
        UNITS = {
          wei:        1,
          kwei:       1000,
    Severity: Minor
    Found in lib/ethereum/formatter.rb - About 2 hrs to fix

      File contract.rb has 260 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

      require 'forwardable'
      
      module Ethereum
        class Contract
      
      
      Severity: Minor
      Found in lib/ethereum/contract.rb - About 2 hrs to fix

        Method create has 37 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            def self.create(file: nil, client: Ethereum::Singleton.instance, code: nil, abi: nil, address: nil, name: nil, contract_index: nil, truffle: nil)
              contract = nil
              if file.present?
                contracts = Ethereum::Initializer.new(file, client).build_all
                raise "No contracts compiled" if contracts.empty?
        Severity: Minor
        Found in lib/ethereum/contract.rb - About 1 hr to fix

          Method build has 26 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              def build
                class_name = @name.camelize
                parent = self
                create_function_proxies
                create_event_proxies
          Severity: Minor
          Found in lib/ethereum/contract.rb - About 1 hr to fix

            Method send_command has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
            Open

                def send_command(command,args)
                  if ["eth_getBalance", "eth_call"].include?(command)
                    args << "latest"
                  end
            
            
            Severity: Minor
            Found in lib/ethereum/client.rb - About 45 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Avoid deeply nested control flow statements.
            Open

                          address = if client
                                      network_id = client.net_version['result']
                                      (artifacts['networks'][network_id]) ? artifacts['networks'][network_id]['address'] : nil
                                    else
                                      nil
            Severity: Major
            Found in lib/ethereum/contract.rb - About 45 mins to fix

              Method wait_for_deployment has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
              Open

                  def wait_for_deployment(timeout: DEFAULT_TIMEOUT, step: DEFAULT_STEP)
                    start_time = Time.now
                    loop do
                      raise "Transaction #{@id} timed out." if ((Time.now - start_time) > timeout) 
                      yield if block_given?
              Severity: Minor
              Found in lib/ethereum/deployment.rb - About 25 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method link_libraries has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
              Open

                  def link_libraries
                    if @needs_linking
                      @libraries.each do |library|
                        name = library[:name]
                        if @project_initializer.libraries[name].nil?
              Severity: Minor
              Found in lib/ethereum/contract_initializer.rb - About 25 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method check_deployed has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
              Open

                  def check_deployed
                    return false unless @id
                    contract_receipt = @connection.eth_get_transaction_receipt(@id)
                    result = contract_receipt["result"]
                    has_contract_address = result && result["contractAddress"]
              Severity: Minor
              Found in lib/ethereum/deployment.rb - About 25 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Severity
              Category
              Status
              Source
              Language