Showing 34 of 49 total issues
File Parser.php
has 389 lines of code (exceeds 250 allowed). Consider refactoring. Open
<?php declare(strict_types=1);
namespace Helmich\TypoScriptParser\Parser;
use ArrayObject;
The class TokenStream has 11 public methods. Consider refactoring TokenStream to keep number of public methods under 10. Open
class TokenStream implements Iterator, ArrayAccess
{
/**
* @var TokenInterface[]
*/
- Read upRead up
- Exclude checks
TooManyPublicMethods
Since: 0.1
A class with too many public methods is probably a good suspect for refactoring, in order to reduce its complexity and find a way to have more fine grained objects.
By default it ignores methods starting with 'get' or 'set'.
Example
Source https://phpmd.org/rules/codesize.html#toomanypublicmethods
The class Builder has 11 public methods. Consider refactoring Builder to keep number of public methods under 10. Open
class Builder
{
private Operator\Builder $operatorBuilder;
/**
- Read upRead up
- Exclude checks
TooManyPublicMethods
Since: 0.1
A class with too many public methods is probably a good suspect for refactoring, in order to reduce its complexity and find a way to have more fine grained objects.
By default it ignores methods starting with 'get' or 'set'.
Example
Source https://phpmd.org/rules/codesize.html#toomanypublicmethods
The class Parser has an overall complexity of 69 which is very high. The configured complexity threshold is 50. Open
class Parser implements ParserInterface
{
private TokenizerInterface $tokenizer;
private Builder $builder;
- Exclude checks
Method parseCondition
has 71 lines of code (exceeds 25 allowed). Consider refactoring. Open
private function parseCondition(ParserState $state): void
{
if ($state->context()->depth() !== 0) {
throw new ParseError(
'Found condition statement inside nested assignment.',
Function tokenizeString
has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring. Open
public function tokenizeString(string $inputString): array
{
$inputString = $this->preprocessor->preprocess($inputString);
$tokens = new TokenStreamBuilder();
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
File Tokenizer.php
has 258 lines of code (exceeds 250 allowed). Consider refactoring. Open
<?php
declare(strict_types=1);
namespace Helmich\TypoScriptParser\Tokenizer;
Method tokenizeBinaryObjectOperation
has 49 lines of code (exceeds 25 allowed). Consider refactoring. Open
private function tokenizeBinaryObjectOperation(TokenStreamBuilder $tokens, array $matches, int $currentLine): void
{
$tokens->append(
$this->getTokenTypeForBinaryOperator($matches[3]),
$matches[3],
Method tokenizeString
has 45 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function tokenizeString(string $inputString): array
{
$inputString = $this->preprocessor->preprocess($inputString);
$tokens = new TokenStreamBuilder();
Function parseCondition
has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring. Open
private function parseCondition(ParserState $state): void
{
if ($state->context()->depth() !== 0) {
throw new ParseError(
'Found condition statement inside nested assignment.',
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method printStatementList
has 43 lines of code (exceeds 25 allowed). Consider refactoring. Open
private function printStatementList(array $statements, OutputInterface $output, int $nesting = 0): void
{
if ($nesting === 0) {
$statements = $this->trimTrailingNoops($statements);
}
Method parseToken
has 42 lines of code (exceeds 25 allowed). Consider refactoring. Open
private function parseToken(ParserState $state): void
{
switch ($state->token()->getType()) {
case TokenInterface::TYPE_OBJECT_IDENTIFIER:
$objectPath = $state->context()->append($state->token()->getValue());
Function printStatementList
has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring. Open
private function printStatementList(array $statements, OutputInterface $output, int $nesting = 0): void
{
if ($nesting === 0) {
$statements = $this->trimTrailingNoops($statements);
}
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method parseNestedStatements
has 29 lines of code (exceeds 25 allowed). Consider refactoring. Open
private function parseNestedStatements(ParserState $state, ?int $startLine = null): void
{
$startLine = $startLine ?? $state->token()->getLine();
$statements = new ArrayObject();
$subContext = $state->withStatements($statements);
Method parseAssignment
has 27 lines of code (exceeds 25 allowed). Consider refactoring. Open
private function parseAssignment(ParserState $state): void
{
switch ($state->token(2)->getType()) {
case TokenInterface::TYPE_OBJECT_CONSTRUCTOR:
$state->statements()->append($this->builder->op()->objectCreation(
Function parseToken
has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring. Open
private function parseToken(ParserState $state): void
{
switch ($state->token()->getType()) {
case TokenInterface::TYPE_OBJECT_IDENTIFIER:
$objectPath = $state->context()->append($state->token()->getValue());
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function parseNestedStatements
has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring. Open
private function parseNestedStatements(ParserState $state, ?int $startLine = null): void
{
$startLine = $startLine ?? $state->token()->getLine();
$statements = new ArrayObject();
$subContext = $state->withStatements($statements);
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function tokenizeBinaryObjectOperation
has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring. Open
private function tokenizeBinaryObjectOperation(TokenStreamBuilder $tokens, array $matches, int $currentLine): void
{
$tokens->append(
$this->getTokenTypeForBinaryOperator($matches[3]),
$matches[3],
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method __construct
has 5 arguments (exceeds 4 allowed). Consider refactoring. Open
public function __construct(string $condition, array $ifStatements, array $elseStatements, int $sourceLine, bool $unterminated = false)
Method condition
has 5 arguments (exceeds 4 allowed). Consider refactoring. Open
public function condition(string $condition, array $if, array $else, int $line, bool $unterminated = false): ConditionalStatement