Sign upLogin

matheuswhite/bluebees

View on GitHub
Star
bluebees/client/node/commands/new.py

Summary

Maintainability
A
1 hr
Test Coverage

Function provisioning_device has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

def provisioning_device(device_uuid: bytes, network: str,
Severity: Minor
Found in bluebees/client/node/commands/new.py - About 35 mins to fix

    Function new has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

    def new(name, network, address, uuid, template):
    Severity: Minor
    Found in bluebees/client/node/commands/new.py - About 35 mins to fix

      Function validate_addr has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

      def validate_addr(ctx, param, value):
    if not value:
        raise click.BadParameter('The maximum number of nodes was '
                                 'reached')
    if not check_hex_string(value):
      Severity: Minor
      Found in bluebees/client/node/commands/new.py - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Expected 2 blank lines, found 1
      Open

      def provisioning_device(device_uuid: bytes, network: str,
      Severity: Minor
      Found in bluebees/client/node/commands/new.py by pep8

      Separate top-level function and class definitions with two blank lines.

      Method definitions inside a class are separated by a single blank
line.

Extra blank lines may be used (sparingly) to separate groups of
related functions.  Blank lines may be omitted between a bunch of
related one-liners (e.g. a set of dummy implementations).

Use blank lines in functions, sparingly, to indicate logical
sections.

Okay: def a():\n    pass\n\n\ndef b():\n    pass
Okay: def a():\n    pass\n\n\nasync def b():\n    pass
Okay: def a():\n    pass\n\n\n# Foo\n# Bar\n\ndef b():\n    pass
Okay: default = 1\nfoo = 1
Okay: classify = 1\nfoo = 1

E301: class Foo:\n    b = 0\n    def bar():\n        pass
E302: def a():\n    pass\n\ndef b(n):\n    pass
E302: def a():\n    pass\n\nasync def b(n):\n    pass
E303: def a():\n    pass\n\n\n\ndef b(n):\n    pass
E303: def a():\n\n\n\n    pass
E304: @decorator\n\ndef a():\n    pass
E305: def a():\n    pass\na()
E306: def a():\n    def b():\n        pass\n    def c():\n        pass

      Line too long (89 > 79 characters)
      Open

                  template_helper.update_sequence(tmpl, 'address', custom_pattern=tmpl['name'])
      Severity: Minor
      Found in bluebees/client/node/commands/new.py by pep8

      Limit all lines to a maximum of 79 characters.

      There are still many devices around that are limited to 80 character
lines; plus, limiting windows to 80 characters makes it possible to
have several windows side-by-side.  The default wrapping on such
devices looks ugly.  Therefore, please limit all lines to a maximum
of 79 characters. For flowing long blocks of text (docstrings or
comments), limiting the length to 72 characters is recommended.

Reports error E501.

      Line too long (110 > 79 characters)
      Open

              address, addr_is_seq = template_helper.get_field(template, 'address', custom_pattern=template['name'])
      Severity: Minor
      Found in bluebees/client/node/commands/new.py by pep8

      Limit all lines to a maximum of 79 characters.

      There are still many devices around that are limited to 80 character
lines; plus, limiting windows to 80 characters makes it possible to
have several windows side-by-side.  The default wrapping on such
devices looks ugly.  Therefore, please limit all lines to a maximum
of 79 characters. For flowing long blocks of text (docstrings or
comments), limiting the length to 72 characters is recommended.

Reports error E501.

      Line too long (83 > 79 characters)
      Open

      from bluebees.client.node.node_data import NodeData, node_name_list, node_addr_list
      Severity: Minor
      Found in bluebees/client/node/commands/new.py by pep8

      Limit all lines to a maximum of 79 characters.

      There are still many devices around that are limited to 80 character
lines; plus, limiting windows to 80 characters makes it possible to
have several windows side-by-side.  The default wrapping on such
devices looks ugly.  Therefore, please limit all lines to a maximum
of 79 characters. For flowing long blocks of text (docstrings or
comments), limiting the length to 72 characters is recommended.

Reports error E501.

      There are no issues that match your filters.

      Category
      Status