Sign upLogin

matkoniecz/CartoCSSHelper

View on GitHub
Star
lib/cartocss_helper.rb

Summary

Maintainability
D
1 day
Test Coverage

Method visualise_place_by_file has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
Open

  def self.visualise_place_by_file(filename, latitude, longitude, zlevels, new_branch, old_branch = 'master', header = nil, bb = 0.04, image_size = 350)
    raise "#{filename} does not exists" unless File.exist?(filename)
    raise "#{latitude} is not a number" unless latitude.is_a? Numeric
    raise "#{longitude} is not a number" unless longitude.is_a? Numeric
    raise "#{zlevels} is not a range" unless zlevels.class == Range
Severity: Minor
Found in lib/cartocss_helper.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method visualise_place_by_url has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
Open

  def self.visualise_place_by_url(url, zlevels, new_branch, old_branch = 'master', header = nil, download_bbox_size = 0.04, image_size = 350)
    header = url if header == nil

    raise "#{url} is not a string, it is #{url.class}" unless url.class == String
    raise "#{zlevels} is not a range, it is #{zlevels.class}" unless zlevels.class == Range
Severity: Minor
Found in lib/cartocss_helper.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method visualise_place_by_file has 9 arguments (exceeds 4 allowed). Consider refactoring.
Open

  def self.visualise_place_by_file(filename, latitude, longitude, zlevels, new_branch, old_branch = 'master', header = nil, bb = 0.04, image_size = 350)
Severity: Major
Found in lib/cartocss_helper.rb - About 1 hr to fix

    Method visualise_place_by_remote_file has 9 arguments (exceeds 4 allowed). Consider refactoring.
    Open

      def self.visualise_place_by_remote_file(url, latitude, longitude, zlevels, new_branch, old_branch = 'master', header = nil, bb = 0.04, image_size = 350)
    Severity: Major
    Found in lib/cartocss_helper.rb - About 1 hr to fix

      Method visualise_place_by_url has 7 arguments (exceeds 4 allowed). Consider refactoring.
      Open

        def self.visualise_place_by_url(url, zlevels, new_branch, old_branch = 'master', header = nil, download_bbox_size = 0.04, image_size = 350)
      Severity: Major
      Found in lib/cartocss_helper.rb - About 50 mins to fix

        Method test_tag_on_real_data_for_this_type has 7 arguments (exceeds 4 allowed). Consider refactoring.
        Open

          def self.test_tag_on_real_data_for_this_type(tags, new_branch, old_branch, zlevels, type, min = 4, skip = 0)
        Severity: Major
        Found in lib/cartocss_helper.rb - About 50 mins to fix

          Method test_tag_on_real_data has 7 arguments (exceeds 4 allowed). Consider refactoring.
          Open

            def self.test_tag_on_real_data(tags, new_branch, old_branch, zlevels, types = ['node', 'closed_way', 'way'], min = 4, skip = 0)
          Severity: Major
          Found in lib/cartocss_helper.rb - About 50 mins to fix

            Method probe has 6 arguments (exceeds 4 allowed). Consider refactoring.
            Open

              def self.probe(tags, new_branch, old_branch = 'master', zlevels = Configuration.get_min_z..Configuration.get_max_z, types = ['node', 'closed_way', 'way'], test_on_water = false)
            Severity: Minor
            Found in lib/cartocss_helper.rb - About 45 mins to fix

              Method test_tag_on_sythetic_data has 6 arguments (exceeds 4 allowed). Consider refactoring.
              Open

                def self.test_tag_on_sythetic_data(tags, new_branch, old_branch = 'master', zlevels = Configuration.get_min_z..Configuration.get_max_z, types = ['node', 'closed_way', 'way'], test_on_water = false)
              Severity: Minor
              Found in lib/cartocss_helper.rb - About 45 mins to fix

                Method test has 6 arguments (exceeds 4 allowed). Consider refactoring.
                Open

                  def self.test(tags, new_branch, old_branch = 'master', zlevels = Configuration.get_min_z..Configuration.get_max_z, types = ['node', 'closed_way', 'way'], test_on_water = false)
                Severity: Minor
                Found in lib/cartocss_helper.rb - About 45 mins to fix

                  Method test_tag_on_real_data_for_this_type has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                  Open

                    def self.test_tag_on_real_data_for_this_type(tags, new_branch, old_branch, zlevels, type, min = 4, skip = 0)
    type = type[0] if type.is_a?(Array)
    generated = 0

    n = 0
                  Severity: Minor
                  Found in lib/cartocss_helper.rb - About 35 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                    def self.probe(tags, new_branch, old_branch = 'master', zlevels = Configuration.get_min_z..Configuration.get_max_z, types = ['node', 'closed_way', 'way'], test_on_water = false)
    syn_tags = add_common_secondary_tags(tags)
    types.each do |type|
      CartoCSSHelper::VisualDiff.visualise_on_synthethic_data(syn_tags, type, test_on_water, zlevels, new_branch, old_branch)
                  Severity: Minor
                  Found in lib/cartocss_helper.rb and 1 other location - About 35 mins to fix
                  lib/cartocss_helper.rb on lines 60..63

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 34.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                    def self.test_tag_on_sythetic_data(tags, new_branch, old_branch = 'master', zlevels = Configuration.get_min_z..Configuration.get_max_z, types = ['node', 'closed_way', 'way'], test_on_water = false)
    syn_tags = add_common_secondary_tags(tags)
    types.each do |type|
      CartoCSSHelper::VisualDiff.visualise_on_synthethic_data(syn_tags, type, test_on_water, zlevels, new_branch, old_branch)
                  Severity: Minor
                  Found in lib/cartocss_helper.rb and 1 other location - About 35 mins to fix
                  lib/cartocss_helper.rb on lines 73..76

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 34.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  There are no issues that match your filters.

                  Category
                  Status