Sign upLogin

matteolc/t2_airtime

View on GitHub
Star
lib/t2_airtime/serializer.rb

Summary

Maintainability
D
2 days
Test Coverage

File serializer.rb has 348 lines of code (exceeds 250 allowed). Consider refactoring.
Open

module T2Airtime

  class Topup

    def self.serialize(data, ts = Time.zone.now.to_s)
Severity: Minor
Found in lib/t2_airtime/serializer.rb - About 4 hrs to fix

    Method serialize_one has a Cognitive Complexity of 28 (exceeds 5 allowed). Consider refactoring.
    Open

        def self.serialize_one(data, ts = Time.zone.now.to_s)
      Rails.cache.fetch("transactions/#{data[:transactionid]}/serializer", expires_in: 365.days) do
        {
          type: 'transactions',
          id: Integer(data[:transactionid]),
    Severity: Minor
    Found in lib/t2_airtime/serializer.rb - About 4 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method serialize_one has 63 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        def self.serialize_one(data, ts = Time.zone.now.to_s)
      Rails.cache.fetch("transactions/#{data[:transactionid]}/serializer", expires_in: 365.days) do
        {
          type: 'transactions',
          id: Integer(data[:transactionid]),
    Severity: Major
    Found in lib/t2_airtime/serializer.rb - About 2 hrs to fix

      Method serialize has 43 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          def self.serialize(data, ts = Time.zone.now.to_s, qty = 'all')
      return [] if data[:product_list].nil?
      ids = data[:product_list].split(',')
      retail_prices = data[:retail_price_list].split(',')
      wholesale_prices = data[:wholesale_price_list].split(',')
      Severity: Minor
      Found in lib/t2_airtime/serializer.rb - About 1 hr to fix

        Method serialize has 35 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            def self.serialize(data, ts = Time.zone.now.to_s)
      {
        type: 'topup',
        balance: data[:balance],
        balanceDisplay: "#{Money.new(Integer(data[:balance]) * 100, Account.currency).format}",
        Severity: Minor
        Found in lib/t2_airtime/serializer.rb - About 1 hr to fix

          Method serialize has 27 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              def self.serialize(data, ts = Time.zone.now.to_s, qty = 'all')
      return [] if data[:operator].nil?
      names = data[:operator].split(',')
      ids = data[:operatorid].split(',')
      Rails.cache.fetch("operators/#{data[:countryid]}/serializer", expires_in: 1.hour) do
          Severity: Minor
          Found in lib/t2_airtime/serializer.rb - About 1 hr to fix

            Method take has 6 arguments (exceeds 4 allowed). Consider refactoring.
            Open

                def self.take(start = (Time.now - 24.hours), stop = Time.now, msisdn = nil, destination = nil, code = nil, qty = 5)
            Severity: Minor
            Found in lib/t2_airtime/serializer.rb - About 45 mins to fix

              Method alpha3 has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
              Open

                  def self.alpha3(name)
      alpha3 = ISO3166::Country.find_country_by_name(name).try(:alpha3)
      unless alpha3
        alpha3 = case name
                 when 'Saint Vincent Grenadines'
              Severity: Minor
              Found in lib/t2_airtime/serializer.rb - About 35 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method take has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
              Open

                  def self.take(qty = 5, operator_qty = 1, country_qty = 1)
      operators = T2Airtime::Operator.take(operator_qty, country_qty).shuffle
      unless operators.empty?
        operators.flat_map do |operator| (          
          products = all(operator[:id])
              Severity: Minor
              Found in lib/t2_airtime/serializer.rb - About 25 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method take has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
              Open

                  def self.take(qty = 5, country_qty = 1)
      countries = T2Airtime::Country.take(country_qty).shuffle
      unless countries.empty?
        countries.flat_map do |country| (          
          operators = all(country[:id])
              Severity: Minor
              Found in lib/t2_airtime/serializer.rb - About 25 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                    unless countries.empty?
        countries.flat_map do |country| (          
          operators = all(country[:id])
          operators.success? ? serialize(operators.data, operators.headers[:date], qty) : []
        )
              Severity: Minor
              Found in lib/t2_airtime/serializer.rb and 1 other location - About 15 mins to fix
              lib/t2_airtime/serializer.rb on lines 234..238

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 25.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                    unless operators.empty?
        operators.flat_map do |operator| (          
          products = all(operator[:id])
          products.success? ? serialize(products.data, products.headers[:date], qty) : []
        )
              Severity: Minor
              Found in lib/t2_airtime/serializer.rb and 1 other location - About 15 mins to fix
              lib/t2_airtime/serializer.rb on lines 185..189

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 25.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status