Sign upLogin

mauriciabad/GradeCalc

View on GitHub
Star

Showing 76 of 76 total issues

Avoid too many return statements within this function.
Open

    return false;
Severity: Major
Found in src/scripts/script.js - About 30 mins to fix

    Avoid too many return statements within this function.
    Open

                if (!now && values[tree['left'].name] == undefined) return true;
    Severity: Major
    Found in src/scripts/script.js - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

          return false;
      Severity: Major
      Found in src/scripts/script.js - About 30 mins to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

              (element.dataset.exam == undefined ||
        parseInt(element.dataset.exam) < parseInt(grid.dataset.exams))
        Severity: Minor
        Found in src/scripts/script.js and 1 other location - About 30 mins to fix
        src/scripts/script.js on lines 1703..1705

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 45.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Avoid too many return statements within this function.
        Open

            return false;
        Severity: Major
        Found in src/scripts/script.js - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

            return true;
          Severity: Major
          Found in src/scripts/script.js - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

                          return (values[tree['left'].name] || 0) < tree['lerightft'].value;
            Severity: Major
            Found in src/scripts/script.js - About 30 mins to fix

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                      case 'exam':
          element.style.gridRow = `${
            parseInt(element.dataset[type]) + 2
          } / auto`;
          break;
              Severity: Minor
              Found in src/scripts/script.js and 1 other location - About 30 mins to fix
              src/scripts/script.js on lines 1728..1732

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 45.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 3 locations. Consider refactoring.
              Open

                    appendElement(
        grid,
        `<input style="grid-row: ${
          2 + parseInt(grid.dataset.exams)
        }; grid-column: 1;" class="edit-new-exam" type="text"   name="exam"       value="" data-exam="${
              Severity: Minor
              Found in src/scripts/script.js and 2 other locations - About 30 mins to fix
              src/scripts/script.js on lines 1616..1623
              src/scripts/script.js on lines 1624..1631

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 45.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Avoid too many return statements within this function.
              Open

                  return false;
              Severity: Major
              Found in src/scripts/script.js - About 30 mins to fix

                Avoid too many return statements within this function.
                Open

                    return false;
                Severity: Major
                Found in src/scripts/script.js - About 30 mins to fix

                  Similar blocks of code found in 3 locations. Consider refactoring.
                  Open

                        appendElement(
        grid,
        `<input style="grid-row: ${
          2 + parseInt(grid.dataset.exams)
        }; grid-column: 2;" class="edit-new-exam" type="text"   name="examType"   value="" data-exam="${
                  Severity: Minor
                  Found in src/scripts/script.js and 2 other locations - About 30 mins to fix
                  src/scripts/script.js on lines 1608..1615
                  src/scripts/script.js on lines 1624..1631

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 45.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                        (element.dataset.evaluation == undefined ||
        parseInt(element.dataset.evaluation) <
          parseInt(grid.dataset.evaluations)) &&
                  Severity: Minor
                  Found in src/scripts/script.js and 1 other location - About 30 mins to fix
                  src/scripts/script.js on lines 1706..1707

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 45.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Function updateFinalMark has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                  Open

                    updateFinalMark() {
    for (const evaluation in this.evaluations) {
      this.finalMark[evaluation] = 0;
      for (const exam in this.evaluations[evaluation].exams) {
        if (!this.isExamUndone(exam)) this.finalMark[evaluation] += this.grades[exam] * this.evaluations[evaluation].exams[exam].weight;
                  Severity: Minor
                  Found in src/scripts/subject.js - About 25 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Function sortSubjectExams has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                  Open

                  function sortSubjectExams(subject) {
  let newSubject = { ...subject };

  for (const evaluation in subject.evaluations) {
    const examsSortedArray = Object.keys(subject.evaluations[evaluation].exams)
                  Severity: Minor
                  Found in src/scripts/script.js - About 25 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Function updateCardGrades has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                  Open

                  function updateCardGrades(id) {
  let card = getCard(id);
  for (let div of card.getElementsByClassName('subject-bar')[0].children) {
    div.classList.add('scolN');
  }
                  Severity: Minor
                  Found in src/scripts/script.js - About 25 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Severity
                  Category
                  Status
                  Source
                  Language