Sign upLogin

mauritsl/node-castor-client

View on GitHub
Star
classes/Transport.js

Summary

Maintainability
B
4 hrs
Test Coverage

Function connect has 39 lines of code (exceeds 25 allowed). Consider refactoring.
Open

Transport.prototype.connect = function() {
  var self = this;
  
  if (new Date() - this._lastConnectAttempt < 5000) {
    return;
Severity: Minor
Found in classes/Transport.js - About 1 hr to fix

    Function _fetchFrames has 28 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    Transport.prototype._fetchFrames = function() {
  // We need at least 8 bytes for the frame header.
  while (this._inputBuffer.length >= 8) {
    var length = 8 + this._inputBuffer.readUInt32BE(4);
    if (this._inputBuffer.length < length) {
    Severity: Minor
    Found in classes/Transport.js - About 1 hr to fix

      Function _fetchFrames has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
      Open

      Transport.prototype._fetchFrames = function() {
  // We need at least 8 bytes for the frame header.
  while (this._inputBuffer.length >= 8) {
    var length = 8 + this._inputBuffer.readUInt32BE(4);
    if (this._inputBuffer.length < length) {
      Severity: Minor
      Found in classes/Transport.js - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function Transport has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

      var Transport = function(host, readyCallback) {
  var self = this;
  
  // Used for validating the connection in the connection pool.
  this.ready = false;
      Severity: Minor
      Found in classes/Transport.js - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status