mbland/custom-links

Function assembleApiRouter has 63 lines of code (exceeds 25 allowed). Consider refactoring.

Open

function assembleApiRouter(linkDb, logger) {
  var router = express.Router(),
      jsonParser = bodyParser.json(),
      linkParam = ':link(/[A-Za-z0-9_.-]+)',
      userParam = ':user([A-Za-z0-9_.-]+@?[A-Za-z0-9_.-]+)'

Function assembleApp has 26 lines of code (exceeds 25 allowed). Consider refactoring.

Open

function assembleApp(app, linkDb, logger, sessionStore, config) {
  auth.assemble(passport, linkDb, config)
  app.use(session(sessionParams(config, sessionStore)))
  app.use(passport.initialize())
  app.use(passport.session())

Function assembleApp has 5 arguments (exceeds 4 allowed). Consider refactoring.

Open

function assembleApp(app, linkDb, logger, sessionStore, config) {

Function addApiHandlers has 5 arguments (exceeds 4 allowed). Consider refactoring.

Open

function addApiHandlers(req, res, okStatus, logger, linkDbOp) {

Similar blocks of code found in 3 locations. Consider refactoring.

Open

  router.post('/owner' + linkParam, jsonParser, (req, res) => {
    addApiHandlers(req, res, 204, logger, linkDb.changeOwner(
      req.params.link, req.user.id, req.body.owner))
  })

• Read up
  Read up

Similar blocks of code found in 3 locations. Consider refactoring.

Open

  router.post('/create' + linkParam, jsonParser, (req, res) => {
    addApiHandlers(req, res, 201, logger, linkDb.createLink(
      req.params.link, req.body.target, req.user.id))
  })

• Read up
  Read up

Similar blocks of code found in 3 locations. Consider refactoring.

Open

  router.post('/target' + linkParam, jsonParser, (req, res) => {
    addApiHandlers(req, res, 204, logger, linkDb.updateTarget(
      req.params.link, req.user.id, req.body.target))
  })

• Read up
  Read up