mediamonks/seng-scroll-tracker

View on GitHub

Showing 6 of 6 total issues

Function exports has 41 lines of code (exceeds 25 allowed). Consider refactoring.
Open

module.exports = function(config)
{
    config.set({

        // List of test frameworks we will use. Most of them are provided by separate packages (adapters).
Severity: Minor
Found in karma.conf.js - About 1 hr to fix

    Function checkInView has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
    Open

        public checkInView(scrollingBack: boolean = false): boolean {
            const isInView = this.getInViewValue();
            this.isInBounds = this.scrollPosition >= 0 && this.scrollPosition <= this.pointTracker.viewEnd;
            const positionFromStart = this.pointSide === Side.START ?
                this.scrollPosition : this.pointTracker.scrollSize - this.scrollPosition;
    Severity: Minor
    Found in src/lib/ScrollTrackerPoint.ts - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function exports has 30 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    module.exports = function()
    {
        return {
            /**
             * Inline source maps, generated by TypeScript compiler, will be used.
    Severity: Minor
    Found in config/webpack.config.test.js - About 1 hr to fix

      Function exports has 29 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      module.exports = function()
      {
          return {
              resolve: {
                  extensions: ['', '.ts', '.js']
      Severity: Minor
      Found in config/webpack.config.dist.js - About 1 hr to fix

        Function updateSize has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

            public updateSize(): void {
                const isX = this.axis === Axis.X;
                const dimensions = size(this.targetElement);
                this.viewSize = isX ? dimensions[0] : dimensions[1];
        
        
        Severity: Minor
        Found in src/lib/ScrollTracker.ts - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function updateScrollPosition has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

            protected updateScrollPosition() {
                const isX = this.axis === Axis.X;
                if (this.targetElement === window) {
                    this.viewStart = isX ? window.pageXOffset : window.pageYOffset;
                } else {
        Severity: Minor
        Found in src/lib/ScrollTracker.ts - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Severity
        Category
        Status
        Source
        Language