Sign upLogin

meifamily/ptt-alertor

View on GitHub
Star

Showing 61 of 61 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

package author

import (
    log "github.com/Ptt-Alertor/logrus"
Severity: Major
Found in models/author/author.go and 1 other location - About 7 hrs to fix
models/keyword/keyword.go on lines 1..55

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 500.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

package keyword

import (
    log "github.com/Ptt-Alertor/logrus"
Severity: Major
Found in models/keyword/keyword.go and 1 other location - About 7 hrs to fix
models/author/author.go on lines 1..55

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 500.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Method migrateBoard.RunSingle has a Cognitive Complexity of 46 (exceeds 20 allowed). Consider refactoring.
Open

func (migrateBoard) RunSingle(preBoard string, postBoard string) {
    // board list
    if postBoard != "" {
        addBoard(postBoard)
    }
Severity: Minor
Found in jobs/migrateboard.go - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File command.go has 557 lines of code (exceeds 500 allowed). Consider refactoring.
Open

package command

import (
    "bytes"
    "errors"
Severity: Minor
Found in command/command.go - About 3 hrs to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

    func removeAuthors(u *user.User, sub subscription.Subscription, inputs ...string) error {
    sub.Authors = inputs
    if inputs[0] == "*" {
        for _, uSub := range u.Subscribes {
            if strings.EqualFold(uSub.Board, sub.Board) {
    Severity: Major
    Found in command/actions.go and 1 other location - About 3 hrs to fix
    command/actions.go on lines 27..47

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 258.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

    func removeKeywords(u *user.User, sub subscription.Subscription, inputs ...string) error {
    sub.Keywords = inputs
    if inputs[0] == "*" {
        for _, uSub := range u.Subscribes {
            if strings.EqualFold(uSub.Board, sub.Board) {
    Severity: Major
    Found in command/actions.go and 1 other location - About 3 hrs to fix
    command/actions.go on lines 58..78

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 258.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

    package controllers

import (
    "fmt"
    "net/http"
    Severity: Major
    Found in controllers/keyword.go and 1 other location - About 3 hrs to fix
    controllers/author.go on lines 1..31

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 254.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

    package controllers

import (
    "fmt"
    "net/http"
    Severity: Major
    Found in controllers/author.go and 1 other location - About 3 hrs to fix
    controllers/keyword.go on lines 1..31

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 254.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Function HandleCommand has 101 lines of code (exceeds 50 allowed). Consider refactoring.
    Open

    func HandleCommand(text string, userID string, isUser bool) string {
    command := strings.ToLower(strings.Fields(strings.TrimSpace(text))[0])
    if isUser {
        log.WithFields(log.Fields{
            "account": userID,
    Severity: Major
    Found in command/command.go - About 3 hrs to fix

      Function FetchArticle has a Cognitive Complexity of 36 (exceeds 20 allowed). Consider refactoring.
      Open

      func FetchArticle(board, articleCode string) (article.Article, error) {
    reqURL := makeArticleURL(board, articleCode)
    htmlNodes, err := fetchHTML(reqURL)
    if err != nil {
        return article.Article{}, err
      Severity: Minor
      Found in ptt/web/crawler.go - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function FetchArticles has a Cognitive Complexity of 34 (exceeds 20 allowed). Consider refactoring.
      Open

      func FetchArticles(board string, page int) (articles article.Articles, err error) {
    reqURL := makeBoardURL(board, page)
    htmlNodes, err := fetchHTML(reqURL)
    if err != nil {
        return nil, err
      Severity: Minor
      Found in ptt/web/crawler.go - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method Checker.Run has a Cognitive Complexity of 33 (exceeds 20 allowed). Consider refactoring.
      Open

      func (c Checker) Run() {
    ctx, cancel := context.WithCancel(context.Background())
    defer cancel()
    // step 1: check boards which one has new articles
    // check high boards
      Severity: Minor
      Found in jobs/checker.go - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function handleCommandLine has 80 lines of code (exceeds 50 allowed). Consider refactoring.
      Open

      func handleCommandLine(userID, command, text string) string {
    var keywordStr, authorStr, push, boo string
    cl := flag.NewFlagSet("Ptt Alertor: <add|del> <-flag <argument>> <board> [board...]\nexample: add -k ptt -a chodino -p 10 ezsoft", flag.ContinueOnError)
    bf := new(bytes.Buffer)
    cl.SetOutput(bf)
      Severity: Major
      Found in command/command.go - About 2 hrs to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

        func updatePushUp(u *user.User, sub subscription.Subscription, inputs ...string) error {
    up, err := strconv.Atoi(inputs[0])
    if err != nil {
        return err
    }
        Severity: Major
        Found in command/actions.go and 1 other location - About 2 hrs to fix
        command/actions.go on lines 98..114

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 194.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

        func updatePushDown(u *user.User, sub subscription.Subscription, inputs ...string) error {
    down, err := strconv.Atoi(inputs[0])
    if err != nil {
        return err
    }
        Severity: Major
        Found in command/actions.go and 1 other location - About 2 hrs to fix
        command/actions.go on lines 80..96

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 194.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Method migrateBoard.RunSingle has 75 lines of code (exceeds 50 allowed). Consider refactoring.
        Open

        func (migrateBoard) RunSingle(preBoard string, postBoard string) {
    // board list
    if postBoard != "" {
        addBoard(postBoard)
    }
        Severity: Minor
        Found in jobs/migrateboard.go - About 2 hrs to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

          func (File) Update(account string, user interface{}) error {
    userFile := usersDir + account + ".json"
    uJSON, err := json.Marshal(user)
    if err != nil {
        myutil.LogJSONEncode(err, user)
          Severity: Major
          Found in models/user/file.go and 1 other location - About 1 hr to fix
          models/user/file.go on lines 45..62

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 174.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

          func (File) Save(account string, user interface{}) error {
    userFile := usersDir + account + ".json"
    uJSON, err := json.Marshal(user)
    if err != nil {
        myutil.LogJSONEncode(err, user)
          Severity: Major
          Found in models/user/file.go and 1 other location - About 1 hr to fix
          models/user/file.go on lines 64..80

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 174.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Function FetchArticle has 66 lines of code (exceeds 50 allowed). Consider refactoring.
          Open

          func FetchArticle(board, articleCode string) (article.Article, error) {
    reqURL := makeArticleURL(board, articleCode)
    htmlNodes, err := fetchHTML(reqURL)
    if err != nil {
        return article.Article{}, err
          Severity: Minor
          Found in ptt/web/crawler.go - About 1 hr to fix

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

            func (DynamoDB) Delete(boardName string) error {
    dynamo := dynamodb.New(session.New())
    _, err := dynamo.DeleteItem(&dynamodb.DeleteItemInput{
        Key: map[string]*dynamodb.AttributeValue{
            "Board": {
            Severity: Major
            Found in models/board/dynamodb.go and 1 other location - About 1 hr to fix
            models/article/dynamodb.go on lines 124..138

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 167.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Severity
            Category
            Status
            Source
            Language