merencia/node-cron

View on GitHub

Showing 11 of 11 total issues

Function exports has a Cognitive Complexity of 22 (exceeds 5 allowed). Consider refactoring.
Open

module.exports = ( () => {
    function isValidExpression(expression, min, max){
        var options = expression.split(',');
        var regexValidation = /^\d+$|^\*$|^\*\/\d+$/;
        for(var i = 0; i < options.length; i++){
Severity: Minor
Found in src/pattern-validation.js - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function exports has 63 lines of code (exceeds 25 allowed). Consider refactoring.
Open

module.exports = ( () => {
    function isValidExpression(expression, min, max){
        var options = expression.split(',');
        var regexValidation = /^\d+$|^\*$|^\*\/\d+$/;
        for(var i = 0; i < options.length; i++){
Severity: Major
Found in src/pattern-validation.js - About 2 hrs to fix

    Function exports has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
    Open

    module.exports = (() => {
        function convertSteps(expressions){
            var stepValuePattern = /^(.+)\/(\d+)$/;
            for(var i = 0; i < expressions.length; i++){
                var match = stepValuePattern.exec(expressions[i]);
    Severity: Minor
    Found in src/convert-expression/step-values-conversion.js - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function exports has 31 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    module.exports = (() => {
    
        function appendSeccondExpression(expressions){
            if(expressions.length === 5){
                return ['0'].concat(expressions);
    Severity: Minor
    Found in src/convert-expression/index.js - About 1 hr to fix

      Function exports has 29 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      module.exports = ( () => {
          function replaceWithRange(expression, text, init, end) {
      
              var numbers = [];
              var last = parseInt(end);
      Severity: Minor
      Found in src/convert-expression/range-conversion.js - About 1 hr to fix

        Function exports has 28 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        module.exports = (() => {
        
            /**
           * Creates a new task to execute given function when the cron
           *  expression ticks.
        Severity: Minor
        Found in src/node-cron.js - About 1 hr to fix

          Function exports has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
          Open

          module.exports = ( () => {
              function replaceWithRange(expression, text, init, end) {
          
                  var numbers = [];
                  var last = parseInt(end);
          Severity: Minor
          Found in src/convert-expression/range-conversion.js - About 55 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function start has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
          Open

              start(){
                  // clear timeout if exsits
                  this.stop();
          
                  let lastCheck = process.hrtime();
          Severity: Minor
          Found in src/scheduler.js - About 45 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function exports has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
          Open

          module.exports = (() => {
          
              function appendSeccondExpression(expressions){
                  if(expressions.length === 5){
                      return ['0'].concat(expressions);
          Severity: Minor
          Found in src/convert-expression/index.js - About 35 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                      for (var j=0; j<numbers.length; j++){
                          numbers[j] = parseInt(numbers[j]);
                      }
          Severity: Minor
          Found in src/convert-expression/index.js and 1 other location - About 35 mins to fix
          src/convert-expression/range-conversion.js on lines 32..34

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 46.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                  for(var i = 0; i < expressions.length; i++){
                      expressions[i] = convertRange(expressions[i]);
                  }
          Severity: Minor
          Found in src/convert-expression/range-conversion.js and 1 other location - About 35 mins to fix
          src/convert-expression/index.js on lines 26..28

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 46.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Severity
          Category
          Status
          Source
          Language