Sign upLogin

metanorma/gb-agencies

View on GitHub
Star

Showing 4 of 8 total issues

File gb_agencies.rb has 344 lines of code (exceeds 250 allowed). Consider refactoring.
Open

module GbAgencies
  class Agencies
    def initialize(lang, labels = nil, issuer = nil)
      @lang = lang
      @labels = labels || { "PRC" => "", "industry_standard" => "",
Severity: Minor
Found in lib/gb_agencies/gb_agencies.rb - About 4 hrs to fix

    Method docidentifier has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
    Open

        def docidentifier(scope, prefix, mandate, docyear, docnum)
      initslash = %r{^/}.match(docnum)
      dn = case scope
           when nil
             docnum
    Severity: Minor
    Found in lib/gb_agencies/gb_agencies.rb - About 55 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method docidentifier has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        def docidentifier(scope, prefix, mandate, docyear, docnum)
    Severity: Minor
    Found in lib/gb_agencies/gb_agencies.rb - About 35 mins to fix

      Method standard_agency1 has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          def standard_agency1(scope, prefix, mandate)
      case scope
      when "national"
        ret = NATIONAL&.dig(@lang, gb_mandate_suffix(prefix, mandate).to_sym,
                            :admin) || nil
      Severity: Minor
      Found in lib/gb_agencies/gb_agencies.rb - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Severity
      Category
      Status
      Source
      Language