metanorma/html2doc

View on GitHub

Showing 9 of 9 total issues

Method unitalic has 43 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def unitalic(math)
    math.xpath(".//xmlns:r[xmlns:rPr[not(xmlns:scr)]/xmlns:sty[@m:val = 'p']]").each do |x|
      x.wrap("<span #{HTML_NS} style='font-style:normal;'></span>")
    end
    math.xpath(".//xmlns:r[xmlns:rPr[not(xmlns:scr)]/xmlns:sty[@m:val = 'bi']]").each do |x|
Severity: Minor
Found in lib/html2doc/math.rb - About 1 hr to fix

    Method image_cleanup has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
    Open

      def image_cleanup(docxml, dir, localdir)
        docxml.traverse do |i|
          src = i["src"]
          next unless i.element? && %w(img v:imagedata).include?(i.name)
          next if src.nil? || src.empty? || /^http/.match?(src)
    Severity: Minor
    Found in lib/html2doc/mime.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method list2para has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

      def list2para(list)
        return if list.xpath("./li").empty?
    
        list2para_position(list)
        list.xpath("./li").each do |l|
    Severity: Minor
    Found in lib/html2doc/lists.rb - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method progress_conv has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

      def progress_conv(idx, step, total, threshold, msg)
    Severity: Minor
    Found in lib/html2doc/math.rb - About 35 mins to fix

      Method contentid has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

        def contentid(mhtml)
          mhtml.gsub %r{(<img[^>]*?src=")([^"']+)(['"])}m do |m|
            repl = "#{$1}cid:#{File.basename($2)}#{$3}"
            /^data:|^https?:/ =~ $2 ? m : repl
          end.gsub %r{(<v:imagedata[^>]*?src=")([^"']+)(['"])}m do |m|
      Severity: Minor
      Found in lib/html2doc/mime.rb - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method bookmarks has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

        def bookmarks(docxml)
          docxml.xpath("//*[@id][not(@name)][not(@style = 'mso-element:footnote')]")
            .each do |x|
            next if x["id"].empty? ||
              %w(shapetype v:shapetype shape v:shape).include?(x.name)
      Severity: Minor
      Found in lib/html2doc/base.rb - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method image_resize has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

        def image_resize(img, path, maxheight, maxwidth)
          s, realsize = get_image_size(img, path)
          return s if s[0] == nil && s[1] == nil
      
          if img.name == "svg" && !img["viewBox"]
      Severity: Minor
      Found in lib/html2doc/mime.rb - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          s[1] = s[0] * realsize[1] / realsize[0] if s[1].zero? && !s[0].zero?
          s[0] = s[1] * realsize[0] / realsize[1] if s[0].zero? && !s[1].zero?
      Severity: Minor
      Found in lib/html2doc/mime.rb and 1 other location - About 15 mins to fix
      lib/html2doc/mime.rb on lines 88..89

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 25.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          s[0] = s[1] * realsize[0] / realsize[1] if s[0].zero? && !s[1].zero?
          s = [(s[0] * maxheight / s[1]).ceil, maxheight] if s[1] > maxheight
      Severity: Minor
      Found in lib/html2doc/mime.rb and 1 other location - About 15 mins to fix
      lib/html2doc/mime.rb on lines 87..88

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 25.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Severity
      Category
      Status
      Source
      Language