Sign upLogin

meteor/meteor

View on GitHub
Star
packages/webapp/webapp_server.js

Summary

Maintainability
F
1 wk
Test Coverage

File webapp_server.js has 915 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import assert from 'assert';
import { readFileSync, chmodSync, chownSync } from 'fs';
import { createServer } from 'http';
import { userInfo } from 'os';
import { join as pathJoin, dirname as pathDirname } from 'path';
Severity: Major
Found in packages/webapp/webapp_server.js - About 2 days to fix

    Function runWebAppServer has 437 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    function runWebAppServer() {
  var shuttingDown = false;
  var syncQueue = new Meteor._SynchronousQueue();

  var getItemPathname = function(itemUrl) {
    Severity: Major
    Found in packages/webapp/webapp_server.js - About 2 days to fix

      Function runWebAppServer has a Cognitive Complexity of 70 (exceeds 5 allowed). Consider refactoring.
      Open

      function runWebAppServer() {
  var shuttingDown = false;
  var syncQueue = new Meteor._SynchronousQueue();

  var getItemPathname = function(itemUrl) {
      Severity: Minor
      Found in packages/webapp/webapp_server.js - About 1 day to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function staticFilesMiddleware has 111 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      WebAppInternals.staticFilesMiddleware = async function(
  staticFilesByArch,
  req,
  res,
  next
      Severity: Major
      Found in packages/webapp/webapp_server.js - About 4 hrs to fix

        Function generateClientProgram has 98 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          function generateClientProgram(
    arch,
    staticFilesByArch = WebAppInternals.staticFilesByArch
  ) {
    const clientDir = pathJoin(
        Severity: Major
        Found in packages/webapp/webapp_server.js - About 3 hrs to fix

          Function staticFilesMiddleware has a Cognitive Complexity of 25 (exceeds 5 allowed). Consider refactoring.
          Open

          WebAppInternals.staticFilesMiddleware = async function(
  staticFilesByArch,
  req,
  res,
  next
          Severity: Minor
          Found in packages/webapp/webapp_server.js - About 3 hrs to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function main has 65 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

            exports.main = argv => {
    WebAppInternals.generateBoilerplate();

    const startHttpServer = listenOptions => {
      WebApp.startListening(
          Severity: Major
          Found in packages/webapp/webapp_server.js - About 2 hrs to fix

            Function generateBoilerplateInstance has 44 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

            WebAppInternals.generateBoilerplateInstance = function(
  arch,
  manifest,
  additionalOptions
) {
            Severity: Minor
            Found in packages/webapp/webapp_server.js - About 1 hr to fix

              Function getBoilerplateAsync has 42 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

              function getBoilerplateAsync(request, arch) {
  let boilerplate = boilerplateByArch[arch];
  runtimeConfig.hooks.forEach(hook => {
    const meteorRuntimeConfig = hook({
      arch,
              Severity: Minor
              Found in packages/webapp/webapp_server.js - About 1 hr to fix

                Function categorizeRequest has 41 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                WebApp.categorizeRequest = function(req) {
  if (req.browser && req.arch && typeof req.modern === 'boolean') {
    // Already categorized.
    return req;
  }
                Severity: Minor
                Found in packages/webapp/webapp_server.js - About 1 hr to fix

                  Function categorizeRequest has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
                  Open

                  WebApp.categorizeRequest = function(req) {
  if (req.browser && req.arch && typeof req.modern === 'boolean') {
    // Already categorized.
    return req;
  }
                  Severity: Minor
                  Found in packages/webapp/webapp_server.js - About 1 hr to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Function getStaticFileInfo has 26 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                  function getStaticFileInfo(staticFilesByArch, originalPath, path, arch) {
  if (!hasOwn.call(WebApp.clientPrograms, arch)) {
    return null;
  }
                  Severity: Minor
                  Found in packages/webapp/webapp_server.js - About 1 hr to fix

                    Avoid too many return statements within this function.
                    Open

                        return;
                    Severity: Major
                    Found in packages/webapp/webapp_server.js - About 30 mins to fix

                      Avoid too many return statements within this function.
                      Open

                            return getBoilerplateAsync(request, arch)
        .then(({ stream, statusCode, headers: newHeaders }) => {
          if (!statusCode) {
            statusCode = res.statusCode ? res.statusCode : 200;
          }
                      Severity: Major
                      Found in packages/webapp/webapp_server.js - About 30 mins to fix

                        Avoid too many return statements within this function.
                        Open

                                return;
                        Severity: Major
                        Found in packages/webapp/webapp_server.js - About 30 mins to fix

                          Avoid too many return statements within this function.
                          Open

                              return;
                          Severity: Major
                          Found in packages/webapp/webapp_server.js - About 30 mins to fix

                            Similar blocks of code found in 2 locations. Consider refactoring.
                            Open

                                  if (request.url.query && request.url.query['meteor_dont_serve_index']) {
        // When downloading files during a Cordova hot code push, we need
        // to detect if a file is not available instead of inadvertently
        // downloading the default index page.
        // So similar to the situation above, we serve an uncached 404.
                            Severity: Major
                            Found in packages/webapp/webapp_server.js and 1 other location - About 1 hr to fix
                            packages/webapp/webapp_server.js on lines 1234..1243

                            Duplicated Code

                            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                            Tuning

                            This issue has a mass of 71.

                            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                            Refactorings

                            Further Reading

                            Similar blocks of code found in 2 locations. Consider refactoring.
                            Open

                                  if (request.url.query && request.url.query['meteor_js_resource']) {
        // Similarly, we're requesting a JS resource that we don't have.
        // Serve an uncached 404. (We can't use the same hack we use for CSS,
        // because actually acting on that hack requires us to have the JS
        // already!)
                            Severity: Major
                            Found in packages/webapp/webapp_server.js and 1 other location - About 1 hr to fix
                            packages/webapp/webapp_server.js on lines 1245..1254

                            Duplicated Code

                            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                            Tuning

                            This issue has a mass of 71.

                            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                            Refactorings

                            Further Reading

                            Identical blocks of code found in 2 locations. Consider refactoring.
                            Open

                                } else {
      const status = req.method === 'OPTIONS' ? 200 : 405;
      res.writeHead(status, {
        Allow: 'OPTIONS, GET, HEAD',
        'Content-Length': '0',
                            Severity: Major
                            Found in packages/webapp/webapp_server.js and 1 other location - About 1 hr to fix
                            packages/webapp/webapp_server.js on lines 1200..1207

                            Duplicated Code

                            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                            Tuning

                            This issue has a mass of 57.

                            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                            Refactorings

                            Further Reading

                            Identical blocks of code found in 2 locations. Consider refactoring.
                            Open

                                ) {
      const status = req.method === 'OPTIONS' ? 200 : 405;
      res.writeHead(status, {
        Allow: 'OPTIONS, GET, HEAD',
        'Content-Length': '0',
                            Severity: Major
                            Found in packages/webapp/webapp_server.js and 1 other location - About 1 hr to fix
                            packages/webapp/webapp_server.js on lines 597..604

                            Duplicated Code

                            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                            Tuning

                            This issue has a mass of 57.

                            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                            Refactorings

                            Further Reading

                            There are no issues that match your filters.

                            Category
                            Status