Sign upLogin

meteor/meteor

View on GitHub
Star
tools/cli/main.js

Summary

Maintainability
F
5 days
Test Coverage

File main.js has 996 lines of code (exceeds 250 allowed). Consider refactoring.
Open

var showRequireProfile = ('METEOR_PROFILE_REQUIRE' in process.env);
if (showRequireProfile) {
  require('../tool-env/profile-require.js').start();
}
Severity: Major
Found in tools/cli/main.js - About 2 days to fix

    Function springboard has 102 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    var springboard = function (rel, options) {
  options = options || {};
  if (process.env.METEOR_DEBUG_SPRINGBOARD) {
    console.log("WILL SPRINGBOARD TO", rel.getToolsPackageAtVersion());
  }
    Severity: Major
    Found in tools/cli/main.js - About 4 hrs to fix

      Function springboard has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
      Open

      var springboard = function (rel, options) {
  options = options || {};
  if (process.env.METEOR_DEBUG_SPRINGBOARD) {
    console.log("WILL SPRINGBOARD TO", rel.getToolsPackageAtVersion());
  }
      Severity: Minor
      Found in tools/cli/main.js - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function longHelp has 49 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      var longHelp = exports.longHelp = function (commandName) {
  commandName = commandName.trim();
  var parts = commandName.length ? commandName.split(' ') : [];
  var node = commands;
  _.each(parts, function (part) {
      Severity: Minor
      Found in tools/cli/main.js - About 1 hr to fix

        Function Command has 37 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        function Command(options) {
  assert.ok(this instanceof Command);

  options = Object.assign({
    minArgs: 0,
        Severity: Minor
        Found in tools/cli/main.js - About 1 hr to fix

          Function walkCommands has 27 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

            var walkCommands = function (node) {
    _.each(node, function (value, key) {
      if (value instanceof Command) {
        _.each(value.options || {}, function (optionInfo, optionName) {
          var names = ["--" + optionName];
          Severity: Minor
          Found in tools/cli/main.js - About 1 hr to fix

            Avoid deeply nested control flow statements.
            Open

                      if(result.response.statusCode === 200) {
            Console.error("Meteor on Windows does not support running any releases",
              "before Meteor 1.1. Please use a newer release.");
            process.exit(1);
          }
            Severity: Major
            Found in tools/cli/main.js - About 45 mins to fix

              Avoid deeply nested control flow statements.
              Open

                      if (catalog.refreshFailed) {
          Console.error(
            "This project says that it uses " + displayRelease + ", but",
            "you don't have that version of Meteor installed, and we were",
            "unable to contact Meteor's update servers to find out about it.",
              Severity: Major
              Found in tools/cli/main.js - About 45 mins to fix

                Avoid deeply nested control flow statements.
                Open

                            if (!catalog.refreshFailed) {
              // Warn if we didn't already warn.
              Console.warn(
                "Unable to contact release server (are you offline?)");
              Console.warn();
                Severity: Major
                Found in tools/cli/main.js - About 45 mins to fix

                  Avoid deeply nested control flow statements.
                  Open

                            if (remainder.length) {
            // If there's an '=' here, don't include it in the option value. A
            // trailing '=' *should* cause us to set the option value to ''.
            if (remainder.charAt(0) === '=') {
              remainder = remainder.substr(1);
                  Severity: Major
                  Found in tools/cli/main.js - About 45 mins to fix

                    Avoid deeply nested control flow statements.
                    Open

                            if (trackAndVersion[0] !== catalog.DEFAULT_TRACK) {
          displayRelease = "Meteor release " + displayRelease;
        }
                    Severity: Major
                    Found in tools/cli/main.js - About 45 mins to fix

                      Avoid deeply nested control flow statements.
                      Open

                              } else if (isBoolean[subterm] &&
                   j + 1 < term.length && term.charAt(j + 1) === '=') {
          // We know it's a boolean, but we've been given an '='. This will
          // cause a pretty error later.
          if (! _.has(rawOptions, subterm)) {
                      Severity: Major
                      Found in tools/cli/main.js - About 45 mins to fix

                        Function registerCommand has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                        Open

                        main.registerCommand = function (options, func) {
  options = _.clone(options);
  options.func = func;

  var nameParts = options.name.trim().split(/\s+/);
                        Severity: Minor
                        Found in tools/cli/main.js - About 25 mins to fix

                        Cognitive Complexity

                        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                        A method's cognitive complexity is based on a few simple rules:

                        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                        • Code is considered more complex for each "break in the linear flow of the code"
                        • Code is considered more complex when "flow breaking structures are nested"

                        Further reading

                        Similar blocks of code found in 2 locations. Consider refactoring.
                        Open

                              if (value === null) {
        // This option requires a value and they didn't give it one
        // (it was the last word on the command line).
        Console.error(
          Console.command(commandName) + ": the " +
                        Severity: Major
                        Found in tools/cli/main.js and 1 other location - About 1 hr to fix
                        tools/cli/main.js on lines 1321..1390

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 68.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        Similar blocks of code found in 2 locations. Consider refactoring.
                        Open

                            if (values.length > 1) {
      // in the future, we could support multiple values, but we don't
      // for now since no command needs it
      Console.error(
        Console.command(commandName) + ": can only take one " +
                        Severity: Major
                        Found in tools/cli/main.js and 1 other location - About 1 hr to fix
                        tools/cli/main.js on lines 1334..1366

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 68.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        Similar blocks of code found in 2 locations. Consider refactoring.
                        Open

                          if (options.args.length > command.maxArgs) {
    Console.error(
      Console.command(commandName) + ": too many arguments.");
    Console.rawError(
      longHelp(commandName));
                        Severity: Minor
                        Found in tools/cli/main.js and 1 other location - About 55 mins to fix
                        tools/cli/main.js on lines 1403..1409

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 53.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        Similar blocks of code found in 2 locations. Consider refactoring.
                        Open

                          if (options.args.length < command.minArgs) {
    Console.error(
      Console.command(commandName) + ": not enough arguments.");
    Console.rawError(
      longHelp(commandName));
                        Severity: Minor
                        Found in tools/cli/main.js and 1 other location - About 55 mins to fix
                        tools/cli/main.js on lines 1411..1417

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 53.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        There are no issues that match your filters.

                        Category
                        Status