Sign upLogin

meteor/meteor

View on GitHub
Star
tools/isobuild/builder.js

Summary

Maintainability
F
5 days
Test Coverage

File builder.js has 574 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import assert from "assert";
import {WatchSet, readAndWatchFile, sha1} from '../fs/watch';
import files, {
  symlinkWithOverwrite, realpath,
} from '../fs/files';
Severity: Major
Found in tools/isobuild/builder.js - About 1 day to fix

    Function _copyDirectory has 119 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      _copyDirectory({
    from, to,
    ignore,
    specificFiles,
    symlink,
    Severity: Major
    Found in tools/isobuild/builder.js - About 4 hrs to fix

      Function walk has 92 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          const walk = (absFrom, relTo) => {
      if (symlink && ! (relTo in this.usedAsFile)) {
        this._ensureDirectory(files.pathDirname(relTo));
        const absTo = files.pathResolve(this.buildPath, relTo);
        if (this.previousCreatedSymlinks[absFrom] !== relTo) {
      Severity: Major
      Found in tools/isobuild/builder.js - About 3 hrs to fix

        Function reserve has a Cognitive Complexity of 24 (exceeds 5 allowed). Consider refactoring.
        Open

          reserve(relPath, {directory} = {}) {
    // Ensure no trailing slash
    if (relPath.slice(-1) === files.pathSep) {
      relPath = relPath.slice(0, -1);
    }
        Severity: Minor
        Found in tools/isobuild/builder.js - About 3 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function _sanitize has a Cognitive Complexity of 22 (exceeds 5 allowed). Consider refactoring.
        Open

          _sanitize(relPath, isDirectory) {
    const parts = relPath.split(files.pathSep);
    const partsOut = [];
    for (let i = 0; i < parts.length; i++) {
      let part = parts[i];
        Severity: Minor
        Found in tools/isobuild/builder.js - About 3 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function write has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
        Open

          write(relPath, {data, file, hash, sanitize, executable, symlink}) {
    relPath = this._normalizeFilePath(relPath, sanitize);

    let getData = null;
    if (data) {
        Severity: Minor
        Found in tools/isobuild/builder.js - About 2 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function copyTranspiledModules has 44 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          copyTranspiledModules(relativePaths, {
    sourceRootDir,
    targetRootDir = this.outputPath,
    needToTranspile = files.inCheckout(),
  }) {
        Severity: Minor
        Found in tools/isobuild/builder.js - About 1 hr to fix

          Function _copyDirectory has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
          Open

            _copyDirectory({
    from, to,
    ignore,
    specificFiles,
    symlink,
          Severity: Minor
          Found in tools/isobuild/builder.js - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function enter has 41 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

            enter(relPath) {
    const subBuilder = {};
    const relPathWithSep = relPath + files.pathSep;
    const methods = [
      "write",
          Severity: Minor
          Found in tools/isobuild/builder.js - About 1 hr to fix

            Function write has 37 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

              write(relPath, {data, file, hash, sanitize, executable, symlink}) {
    relPath = this._normalizeFilePath(relPath, sanitize);

    let getData = null;
    if (data) {
            Severity: Minor
            Found in tools/isobuild/builder.js - About 1 hr to fix

              Function constructor has 35 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                constructor({
    outputPath,
    previousBuilder,
    // Even though in-place builds are disabled by default on some
    // platforms (Windows), they can be forcibly re-enabled with this
              Severity: Minor
              Found in tools/isobuild/builder.js - About 1 hr to fix

                Function _sanitize has 34 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                  _sanitize(relPath, isDirectory) {
    const parts = relPath.split(files.pathSep);
    const partsOut = [];
    for (let i = 0; i < parts.length; i++) {
      let part = parts[i];
                Severity: Minor
                Found in tools/isobuild/builder.js - About 1 hr to fix

                  Function reserve has 33 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                    reserve(relPath, {directory} = {}) {
    // Ensure no trailing slash
    if (relPath.slice(-1) === files.pathSep) {
      relPath = relPath.slice(0, -1);
    }
                  Severity: Minor
                  Found in tools/isobuild/builder.js - About 1 hr to fix

                    Function _ensureDirectory has 32 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                      _ensureDirectory(relPath) {
    const parts = files.pathNormalize(relPath).split(files.pathSep);
    if (parts.length > 1 && parts[parts.length - 1] === '') {
      // remove trailing slash
      parts.pop();
                    Severity: Minor
                    Found in tools/isobuild/builder.js - About 1 hr to fix

                      Function constructor has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
                      Open

                        constructor({
    outputPath,
    previousBuilder,
    // Even though in-place builds are disabled by default on some
    // platforms (Windows), they can be forcibly re-enabled with this
                      Severity: Minor
                      Found in tools/isobuild/builder.js - About 55 mins to fix

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      Avoid deeply nested control flow statements.
                      Open

                                  if (this.previousUsedAsFile[soFar]) {
              files.unlink(soFar);
            } else {
              needToMkdir = false;
            }
                      Severity: Major
                      Found in tools/isobuild/builder.js - About 45 mins to fix

                        Avoid too many return statements within this function.
                        Open

                                  return;
                        Severity: Major
                        Found in tools/isobuild/builder.js - About 30 mins to fix

                          Avoid too many return statements within this function.
                          Open

                                      return;
                          Severity: Major
                          Found in tools/isobuild/builder.js - About 30 mins to fix

                            Avoid too many return statements within this function.
                            Open

                                      return;
                            Severity: Major
                            Found in tools/isobuild/builder.js - About 30 mins to fix

                              Identical blocks of code found in 2 locations. Consider refactoring.
                              Open

                                  if (relPath.slice(-1) === files.pathSep) {
      relPath = relPath.slice(0, -1);
    }
                              Severity: Minor
                              Found in tools/isobuild/builder.js and 1 other location - About 30 mins to fix
                              tools/isobuild/builder.js on lines 455..457

                              Duplicated Code

                              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                              Tuning

                              This issue has a mass of 45.

                              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                              Refactorings

                              Further Reading

                              Identical blocks of code found in 2 locations. Consider refactoring.
                              Open

                                  if (relPath.slice(-1) === files.pathSep) {
      relPath = relPath.slice(0, -1);
    }
                              Severity: Minor
                              Found in tools/isobuild/builder.js and 1 other location - About 30 mins to fix
                              tools/isobuild/builder.js on lines 424..426

                              Duplicated Code

                              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                              Tuning

                              This issue has a mass of 45.

                              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                              Refactorings

                              Further Reading

                              There are no issues that match your filters.

                              Category
                              Status