File isopack.js
has 983 lines of code (exceeds 250 allowed). Consider refactoring. Open
var compiler = require('./compiler.js');
var archinfo = require('../utils/archinfo');
var _ = require('underscore');
var linker = require('./linker.js');
var buildmessage = require('../utils/buildmessage.js');
Function _makePluginApi
has 118 lines of code (exceeds 25 allowed). Consider refactoring. Open
_makePluginApi: function (pluginName) {
var isopack = this;
/**
* @global
Function _writeTool
has 104 lines of code (exceeds 25 allowed). Consider refactoring. Open
_writeTool: Profile("Isopack#_writeTool", function (builder) {
var self = this;
var pathsToCopy = utils.runGitInCheckout(
'ls-tree',
Function _loadUnibuildsFromPath
has 82 lines of code (exceeds 25 allowed). Consider refactoring. Open
_loadUnibuildsFromPath: function (name, dir, options) {
var self = this;
options = options || {};
// In the tropohouse, isopack paths are symlinks (which can be updated if
`` has 27 functions (exceeds 20 allowed). Consider refactoring. Open
Object.assign(Isopack.prototype, {
// Make a dummy (empty) package that contains nothing of interest.
// XXX used?
initEmpty: function (name) {
var self = this;
Function _makePluginApi
has a Cognitive Complexity of 22 (exceeds 5 allowed). Consider refactoring. Open
_makePluginApi: function (pluginName) {
var isopack = this;
/**
* @global
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function _writeTool
has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring. Open
_writeTool: Profile("Isopack#_writeTool", function (builder) {
var self = this;
var pathsToCopy = utils.runGitInCheckout(
'ls-tree',
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function readMetadataFromDirectory
has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring. Open
Profile("Isopack.readMetadataFromDirectory", function (isopackDirectory) {
var metadata = null;
let originalVersion = null;
// deal with different versions of "isopack.json", backwards compatible
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function ensurePluginsInitialized
has 34 lines of code (exceeds 25 allowed). Consider refactoring. Open
ensurePluginsInitialized: Profile("Isopack#ensurePluginsInitialized", function () {
var self = this;
buildmessage.assertInJob();
Function readMetadataFromDirectory
has 33 lines of code (exceeds 25 allowed). Consider refactoring. Open
Profile("Isopack.readMetadataFromDirectory", function (isopackDirectory) {
var metadata = null;
let originalVersion = null;
// deal with different versions of "isopack.json", backwards compatible
Function saveToPath
has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring. Open
saveToPath: Profile("Isopack#saveToPath", function (outputDir, {
includePreCompilerPluginIsopackVersions,
includeIsopackBuildInfo,
isopackCache = null,
} = {}) {
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function _loadUnibuildsFromPath
has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring. Open
_loadUnibuildsFromPath: function (name, dir, options) {
var self = this;
options = options || {};
// In the tropohouse, isopack paths are symlinks (which can be updated if
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function convertIsopackFormat
has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring. Open
"Isopack.convertIsopackFormat", function (data, fromFormat, toFormat) {
var fromPos = Isopack.knownFormats.indexOf(fromFormat);
var toPos = Isopack.knownFormats.indexOf(toFormat);
var step = fromPos < toPos ? 1 : -1;
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function getSourceFilesUnderSourceRoot
has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring. Open
"Isopack#getSourceFilesUnderSourceRoot", function (sourceRoot) {
var self = this;
var sourceFiles = {};
var anySourceFiles = false;
var addSourceFilesFromWatchSet = function (watchSet) {
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function canWriteLegacyBuilds
has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring. Open
canWriteLegacyBuilds() {
function isResourceSafeForLegacyBuilds(resource) {
// The only new kind of resource is "source"; other resources are
// unchanged from legacy builds.
if (resource.type !== "source") {
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Avoid too many return
statements within this function. Open
return;
Similar blocks of code found in 2 locations. Consider refactoring. Open
registerLinter: function (options, factory) {
Plugin._registerSourceProcessor(options || {}, factory, {
sourceProcessorSet: isopack.sourceProcessors.linter,
methodName: "registerLinter",
featurePackage: "isobuild:linter-plugin"
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 51.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Similar blocks of code found in 2 locations. Consider refactoring. Open
registerCompiler: function (options, factory) {
Plugin._registerSourceProcessor(options || {}, factory, {
sourceProcessorSet: isopack.sourceProcessors.compiler,
methodName: "registerCompiler",
featurePackage: "isobuild:compiler-plugin"
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 51.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76