File meteor-npm.js has 775 lines of code (exceeds 250 allowed). Consider refactoring.

Open

/// Implements the process of managing a package's .npm directory,
/// in which we call `npm install` to install npm dependencies,
/// and a variety of related commands. Notably, we use `npm shrinkwrap`
/// to ensure we get consistent versions of npm sub-dependencies.

Function updateExistingNpmDirectory has 81 lines of code (exceeds 25 allowed). Consider refactoring.

Open

var updateExistingNpmDirectory = function (packageName, newPackageNpmDir,
                                           packageNpmDir, npmDependencies,
                                           quiet) {
  // sanity check on contents of .npm directory
  if (!files.stat(packageNpmDir).isDirectory()) {

Function rebuildIfNonPortable has 73 lines of code (exceeds 25 allowed). Consider refactoring.

Open

Profile("meteorNpm.rebuildIfNonPortable", function (nodeModulesDir) {
  const dirsToRebuild = [];

  function scan(dir, scoped) {
    if (! isDirectory(dir)) {

Function updateExistingNpmDirectory has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.

Open

var updateExistingNpmDirectory = function (packageName, newPackageNpmDir,
                                           packageNpmDir, npmDependencies,
                                           quiet) {
  // sanity check on contents of .npm directory
  if (!files.stat(packageNpmDir).isDirectory()) {

• Read up
  Read up

Function getInstalledDependenciesTree has 59 lines of code (exceeds 25 allowed). Consider refactoring.

Open

function getInstalledDependenciesTree(dir) {
  function ls(nodeModulesDir) {
    let contents;
    try {
      contents = files.readdir(nodeModulesDir).sort();

Function ls has 53 lines of code (exceeds 25 allowed). Consider refactoring.

Open

  function ls(nodeModulesDir) {
    let contents;
    try {
      contents = files.readdir(nodeModulesDir).sort();
    } finally {

Function getProdPackageNames has 50 lines of code (exceeds 25 allowed). Consider refactoring.

Open

export const getProdPackageNames = wrapOptimistic(nodeModulesDir => {
  const names = Object.create(null);
  const dirs = Object.create(null);
  const nodeModulesDirStack = [];

Function updateDependencies has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.

Open

meteorNpm.updateDependencies = function (packageName,
                                         packageNpmDir,
                                         npmDependencies,
                                         quiet) {
  // we make sure to put it beside the original package dir so that

• Read up
  Read up

Function isPortable has 47 lines of code (exceeds 25 allowed). Consider refactoring.

Open

const isPortable = Profile("meteorNpm.isPortable", dir => {
  const lstat = optimisticLStat(dir);
  if (! lstat.isDirectory()) {
    // Non-directory files are portable unless they end with .node.
    return ! dir.endsWith(".node");

Function runNpmCommand has 43 lines of code (exceeds 25 allowed). Consider refactoring.

Open

Profile("meteorNpm.runNpmCommand", function (args, cwd) {
  import { getEnv } from "../cli/dev-bundle-bin-helpers.js";

  const devBundleDir = files.getDevBundle();
  const isWindows = process.platform === "win32";

Function installNpmModule has 42 lines of code (exceeds 25 allowed). Consider refactoring.

Open

const installNpmModule = meteorNpm.installNpmModule = (name, version, dir) => {
  const installArg = utils.isNpmUrl(version)
    ? version
    : `${name}@${version}`;

Function installNpmModule has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.

Open

const installNpmModule = meteorNpm.installNpmModule = (name, version, dir) => {
  const installArg = utils.isNpmUrl(version)
    ? version
    : `${name}@${version}`;

• Read up
  Read up

Function updateDependencies has 38 lines of code (exceeds 25 allowed). Consider refactoring.

Open

meteorNpm.updateDependencies = function (packageName,
                                         packageNpmDir,
                                         npmDependencies,
                                         quiet) {
  // we make sure to put it beside the original package dir so that

Function copyNpmPackageWithSymlinkedNodeModules has 33 lines of code (exceeds 25 allowed). Consider refactoring.

Open

function copyNpmPackageWithSymlinkedNodeModules(fromPkgDir, toPkgDir) {
  files.mkdir_p(toPkgDir);

  let needToHandleNodeModules = false;

Function isPortable has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.

Open

const isPortable = Profile("meteorNpm.isPortable", dir => {
  const lstat = optimisticLStat(dir);
  if (! lstat.isDirectory()) {
    // Non-directory files are portable unless they end with .node.
    return ! dir.endsWith(".node");

• Read up
  Read up

Function getProdPackageNames has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.

Open

export const getProdPackageNames = wrapOptimistic(nodeModulesDir => {
  const names = Object.create(null);
  const dirs = Object.create(null);
  const nodeModulesDirStack = [];

• Read up
  Read up

Function createFreshNpmDirectory has 5 arguments (exceeds 4 allowed). Consider refactoring.

Open

var createFreshNpmDirectory = function (packageName, newPackageNpmDir,
                                        packageNpmDir, npmDependencies, quiet) {

Function updateExistingNpmDirectory has 5 arguments (exceeds 4 allowed). Consider refactoring.

Open

var updateExistingNpmDirectory = function (packageName, newPackageNpmDir,
                                           packageNpmDir, npmDependencies,
                                           quiet) {

Function minimizeDependencyTree has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.

Open

function minimizeDependencyTree(tree) {
  function minimizeModule(module) {
    var version;
    if (module.resolved && ! isUrlFromRegistry(module.resolved)) {
      version = module.resolved;

• Read up
  Read up

Avoid too many return statements within this function.

Open

        return;