meyfa/nsdlib

View on GitHub

Showing 5 of 12 total issues

Method deserialize has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
Open

    private List<String> deserialize(String s)
    {
        if (!s.startsWith("\"") || !s.endsWith("\"")) {
            return Collections.singletonList(s);
        }
Severity: Minor
Found in src/main/java/nsdlib/reader/StructorizerReader.java - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method deserialize has 32 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    private List<String> deserialize(String s)
    {
        if (!s.startsWith("\"") || !s.endsWith("\"")) {
            return Collections.singletonList(s);
        }
Severity: Minor
Found in src/main/java/nsdlib/reader/StructorizerReader.java - About 1 hr to fix

    Method fillRect has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        public abstract void fillRect(int x, int y, int w, int h, RenderColor col);
    Severity: Minor
    Found in src/main/java/nsdlib/rendering/renderer/RenderAdapter.java - About 35 mins to fix

      Method fillRect has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          public void fillRect(int x, int y, int w, int h, RenderColor col)
      Severity: Minor
      Found in src/main/java/nsdlib/rendering/renderer/awt/AwtRenderAdapter.java - About 35 mins to fix

        Method render has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

            @Override
            public void render(RenderAdapter<?> adapter, int x, int y, int w)
            {
                if (children.isEmpty()) {
                    return;
        Severity: Minor
        Found in src/main/java/nsdlib/rendering/parts/ContainerRenderPart.java - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Severity
        Category
        Status
        Source
        Language