Sign upLogin

mguymon/lock_jar

View on GitHub
Star
lib/lock_jar/maven.rb

Summary

Maintainability
A
1 hr
Test Coverage

Method deploy_artifact has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

      def deploy_artifact(notation, file_path, url, deploy_opts = {}, lockjar_opts = {})
Severity: Minor
Found in lib/lock_jar/maven.rb - About 35 mins to fix

Method write_pom has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

      def write_pom(notation, file_path, opts = {})
        opts = { include_resolved: true }.merge(opts)

        maven = Naether::Maven.create_from_notataion(notation)
Severity: Minor
Found in lib/lock_jar/maven.rb - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Closing method call brace must be on the line after the last argument when opening brace is on a separate line from the first argument.
Open

          notation, file_path, url, deploy_opts)
Severity: Minor
Found in lib/lock_jar/maven.rb by rubocop

This cop checks that the closing brace in a method call is either on the same line as the last method argument, or a new line.

When using the symmetrical (default) style:

If a method call's opening brace is on the same line as the first argument of the call, then the closing brace should be on the same line as the last argument of the call.

If an method call's opening brace is on the line above the first argument of the call, then the closing brace should be on the line below the last argument of the call.

When using the new_line style:

The closing brace of a multi-line method call must be on the line after the last argument of the call.

When using the same_line style:

The closing brace of a multi-line method call must be on the same line as the last argument of the call.

Example:

# symmetrical: bad
  # new_line: good
  # same_line: bad
  foo(a,
    b
  )

  # symmetrical: bad
  # new_line: bad
  # same_line: good
  foo(
    a,
    b)

  # symmetrical: good
  # new_line: bad
  # same_line: good
  foo(a,
    b)

  # symmetrical: good
  # new_line: good
  # same_line: bad
  foo(
    a,
    b
  )

%w-literals should be delimited by [ and ].
Open

      def dependencies(pom_path, scopes = %w(compile runtime))
Severity: Minor
Found in lib/lock_jar/maven.rb by rubocop

This cop enforces the consistent usage of %-literal delimiters.

Specify the 'default' key to set all preferred delimiters at once. You can continue to specify individual preferred delimiters to override the default.

Example:

# Style/PercentLiteralDelimiters:
#   PreferredDelimiters:
#     default: '[]'
#     '%i':    '()'

# good
%w[alpha beta] + %i(gamma delta)

# bad
%W(alpha #{beta})

# bad
%I(alpha beta)

There are no issues that match your filters.

Category
Status