Showing 282 of 282 total issues
Identical blocks of code found in 2 locations. Consider refactoring. Open
$scope.loadTagItems = function(query) {
// return filtered parent scope' tagNames with query (which is user input)
return $filter('filter')($scope.data.tagNames, query) || [];
};
- Read upRead up
- Create a ticketCreate a ticket
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 47.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Adjoining classes: .btn-group.open .dropdown-toggle Open
.btn-group.open .dropdown-toggle {
- Create a ticketCreate a ticket
- Exclude checks
Adjoining classes: tags-input .tags.focused Open
tags-input .tags.focused {
- Create a ticketCreate a ticket
- Exclude checks
Rule doesn't have all its properties in alphabetical order. Open
.container .navbar-header,
- Create a ticketCreate a ticket
- Exclude checks
Don't use IDs in selectors. Open
#stale-indicator.unknown,
- Create a ticketCreate a ticket
- Exclude checks
Rule doesn't have all its properties in alphabetical order. Open
#overview .share-label,
- Create a ticketCreate a ticket
- Exclude checks
Rule doesn't have all its properties in alphabetical order. Open
.list-group-item {
- Create a ticketCreate a ticket
- Exclude checks
Fallback background (hex or RGB) should precede RGBA background. Open
background : rgba(0, 0, 0, 0.2);
- Create a ticketCreate a ticket
- Exclude checks
Adjoining classes: .hiddenContent .editbuttonbar button.btn.btn-sm Open
.hiddenContent .editbuttonbar button.btn.btn-sm,
- Create a ticketCreate a ticket
- Exclude checks
Fallback background-color (hex or RGB) should precede RGBA background-color. Open
background-color : rgba(255, 255, 255, 0.1);
- Create a ticketCreate a ticket
- Exclude checks
Don't use IDs in selectors. Open
#stale-indicator .stale-indicator-container {
- Create a ticketCreate a ticket
- Exclude checks
Fallback background-color (hex or RGB) should precede RGBA background-color. Open
background-color : rgba(255, 255, 255, 0.4);
- Create a ticketCreate a ticket
- Exclude checks
Rule doesn't have all its properties in alphabetical order. Open
tags-input .autocomplete .suggestion-item.selected {
- Create a ticketCreate a ticket
- Exclude checks
Adjoining classes: .navbar-nav.navbar-right:last-child Open
.navbar-nav.navbar-right:last-child {
- Create a ticketCreate a ticket
- Exclude checks
Rule doesn't have all its properties in alphabetical order. Open
.pagination li.disabled>a,
- Create a ticketCreate a ticket
- Exclude checks
Rule doesn't have all its properties in alphabetical order. Open
.pagination li.disabled>a:hover,
- Create a ticketCreate a ticket
- Exclude checks
Rule doesn't have all its properties in alphabetical order. Open
#stale-indicator {
- Create a ticketCreate a ticket
- Exclude checks
Adjoining classes: .bar-container.ng-hide Open
.bar-container.ng-hide {
- Create a ticketCreate a ticket
- Exclude checks
Adjoining classes: .viewcontainer.ng-leave Open
.viewcontainer.ng-leave {
- Create a ticketCreate a ticket
- Exclude checks