Sign upLogin

michielbdejong/solid-panes

View on GitHub
Star
src/socialPane.js

Summary

Maintainability
F
1 wk
Test Coverage

Function render has a Cognitive Complexity of 179 (exceeds 5 allowed). Consider refactoring.
Open

  render: function (s, context) {
    var dom = context.dom
    var common = function (x, y) {
      // Find common members of two lists
      var both = []
Severity: Minor
Found in src/socialPane.js - About 3 days to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function render has 407 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  render: function (s, context) {
    var dom = context.dom
    var common = function (x, y) {
      // Find common members of two lists
      var both = []
Severity: Major
Found in src/socialPane.js - About 2 days to fix

    File socialPane.js has 426 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    /*   Social Pane
 **
 **  This outline pane provides social network functions
 **  Using for example the FOAF ontology.
 **  Goal:  A *distributed* version of facebook, advogato, etc etc
    Severity: Minor
    Found in src/socialPane.js - About 6 hrs to fix

      Function buildCheckboxForm has 76 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          var buildCheckboxForm = function (lab, statement, state) {
      var f = dom.createElement('form')
      var input = dom.createElement('input')
      f.appendChild(input)
      var tx = dom.createTextNode(lab)
      Severity: Major
      Found in src/socialPane.js - About 3 hrs to fix

        Function boxHandler has 64 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

              var boxHandler = function (_e) {
        tx.className = 'pendingedit'
        // alert('Should be greyed out')
        if (this.checked) {
          // Add link
        Severity: Major
        Found in src/socialPane.js - About 2 hrs to fix

          Function triageFriends has 57 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              function triageFriends (s) {
      outgoing = kb.each(s, foaf('knows'))
      incoming = kb.each(undefined, foaf('knows'), s) // @@ have to load the friends
      var confirmed = []
      var unconfirmed = []
          Severity: Major
          Found in src/socialPane.js - About 2 hrs to fix

            Avoid deeply nested control flow statements.
            Open

                        if (mutualFriends) {
              for (let i = 0; i < mutualFriends.length; i++) {
                tr.appendChild(
                  dom.createTextNode(',  ' + UI.utils.label(mutualFriends[i]))
                )
            Severity: Major
            Found in src/socialPane.js - About 45 mins to fix

              Avoid deeply nested control flow statements.
              Open

                          if (l > 0) {
              var r = uri.indexOf('/', l + 2)
              var r2 = uri.lastIndexOf('.', r)
              if (r2 > 0) r = r2
              hostlabel = uri.slice(l + 2, r)
              Severity: Major
              Found in src/socialPane.js - About 45 mins to fix

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                        for (let j = 0; j < outgoing.length; j++) {
          if (outgoing[j].sameTerm(friend)) {
            found = true
            break
          }
                Severity: Minor
                Found in src/socialPane.js and 1 other location - About 55 mins to fix
                src/socialPane.js on lines 386..391

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 54.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                        for (let j = 0; j < incoming.length; j++) {
          if (incoming[j].sameTerm(friend)) {
            found = true
            break
          }
                Severity: Minor
                Found in src/socialPane.js and 1 other location - About 55 mins to fix
                src/socialPane.js on lines 400..405

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 54.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                There are no issues that match your filters.

                Category
                Status