Sign upLogin

michielbdejong/solid-ui

View on GitHub
Star

Showing 337 of 337 total issues

Function uploadFiles has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

function uploadFiles (fetcher, files, fileBase, imageBase, successHandler) {
Severity: Minor
Found in src/widgets/dragAndDrop.js - About 35 mins to fix

    Function exports has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

    module.exports = function (dom, kb, subject, messageStore, options) {
    Severity: Minor
    Found in src/messageArea.js - About 35 mins to fix

      Function editFormButton has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

        dom,
  container,
  form,
  store,
  callbackFunction
      Severity: Minor
      Found in src/widgets/forms.js - About 35 mins to fix

        Function putACLbyCombo has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

          kb: $rdf.IndexedFormula,
  x: $rdf.NamedNode,
  byCombo: ComboList,
  aclDoc: $rdf.NamedNode,
  callbackFunction: (ok: boolean, message?: string) => void
        Severity: Minor
        Found in src/acl/acl.ts - About 35 mins to fix

          Function putACLObject has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

            kb: $rdf.IndexedFormula,
  x: $rdf.NamedNode,
  ac: AgentMapMap,
  aclDoc: $rdf.NamedNode,
  callbackFunction
          Severity: Minor
          Found in src/acl/acl.ts - About 35 mins to fix

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

              module.exports.originalIconBase =
    '' +
    module.scriptURI.slice(0, module.scriptURI.lastIndexOf('/')) +
    '/originalIcons/'
            Severity: Minor
            Found in src/iconBase.js and 1 other location - About 35 mins to fix
            src/iconBase.js on lines 6..9

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 47.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                while (sel && sel.currentURI) {
      removeValue(kb.sym(sel.currentURI))
      sel = sel.superSelect
    }
            Severity: Minor
            Found in src/widgets/forms.js and 1 other location - About 35 mins to fix
            src/widgets/forms.js on lines 1672..1675

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 47.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

              module.exports.iconBase =
    '' +
    module.scriptURI.slice(0, module.scriptURI.lastIndexOf('/')) +
    '/icons/'
            Severity: Minor
            Found in src/iconBase.js and 1 other location - About 35 mins to fix
            src/iconBase.js on lines 10..13

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 47.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                while (sel && sel.currentURI) {
      removeValue(kb.sym(sel.currentURI))
      sel = sel.subSelect
    }
            Severity: Minor
            Found in src/widgets/forms.js and 1 other location - About 35 mins to fix
            src/widgets/forms.js on lines 1677..1680

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 47.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Function createIfNotExists has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
            Open

            async function createIfNotExists (doc, contentType = 'text/turtle', data = '') {
  const fetcher = UI.store.fetcher
  try {
    var response = await fetcher.load(doc)
  } catch (err) {
            Severity: Minor
            Found in src/chat/infinite.js - About 35 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function participationObject has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
            Open

            UI.pad.participationObject = function (subject, padDoc, me) {
  return new Promise(function (resolve, reject) {
    if (!me) {
      throw new Error('Not user id')
    }
            Severity: Minor
            Found in src/pad.js - About 35 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function stackString has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
            Open

            function stackString (e) {
  let str = '' + e + '\n'
  let i
  if (!e.stack) {
    return str + 'No stack available.\n'
            Severity: Minor
            Found in src/utils.js - About 35 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function faviconOrDefault has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
            Open

            var faviconOrDefault = function (dom, x) {
  var image = dom.createElement('img')
  image.style = UI.style.iconStyle
  var isOrigin = function (x) {
    if (!x.uri) return false
            Severity: Minor
            Found in src/widgets/buttons.js - About 35 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function propertyTriage has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
            Open

            buttons.propertyTriage = function (kb) {
  var possibleProperties = {}
  // if (possibleProperties === undefined) possibleProperties = {}
  // var kb = UI.store
  var dp = {}
            Severity: Minor
            Found in src/widgets/buttons.js - About 35 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function offlineTestID has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
            Open

            export function offlineTestID (): $rdf.NamedNode | null {
  const { $SolidTestEnvironment }: any = window
  if (
    typeof $SolidTestEnvironment !== 'undefined' &&
    $SolidTestEnvironment.username
            Severity: Minor
            Found in src/authn/authn.ts - About 35 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Avoid too many return statements within this function.
            Open

                  return term.uri + '!?' // strange should have a nice part
            Severity: Major
            Found in src/utils.js - About 30 mins to fix

              Avoid too many return statements within this function.
              Open

                return term.value
              Severity: Major
              Found in src/preferences.js - About 30 mins to fix

                Avoid too many return statements within this function.
                Open

                  if (hash >= 0) return cleanUp(s.slice(hash + 1))
                Severity: Major
                Found in src/utils.js - About 30 mins to fix

                  Avoid too many return statements within this function.
                  Open

                    if (slash >= 0 && slash < x.uri.length) return cleanUp(s.slice(slash + 1))
                  Severity: Major
                  Found in src/utils.js - About 30 mins to fix

                    Avoid too many return statements within this function.
                    Open

                            return span
                    Severity: Major
                    Found in src/table.js - About 30 mins to fix
                      Severity
                      Category
                      Status
                      Source
                      Language