Sign upLogin

michielbdejong/solid-ui

View on GitHub
Star

Showing 337 of 337 total issues

File utils.js has 512 lines of code (exceeds 250 allowed). Consider refactoring.
Open

//                  Solid-UI general Utilities
//                  ==========================
//
// This must load AFTER the rdflib.js and log-ext.js (or log.js).
//
Severity: Major
Found in src/utils.js - About 1 day to fix

    File acl.ts has 511 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    // Access control logic

import * as $rdf from 'rdflib'
import ns from '../ns'
import kb from '../store.js'
    Severity: Major
    Found in src/acl/acl.ts - About 1 day to fix

      Function matrixForQuery has 185 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      module.exports.matrixForQuery = function (
  dom,
  query,
  vx,
  vy,
      Severity: Major
      Found in src/matrix.js - About 7 hrs to fix

        Function newThingUI has 184 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        function newThingUI (createContext, dataBrowserContext, thePanes) {
  if (!thePanes) throw new Error('@@ newThingUI: update API') // phase out
  const dom = createContext.dom
  const div = createContext.div
  if (createContext.me && !createContext.me.uri) {
        Severity: Major
        Found in src/create.js - About 7 hrs to fix

          Function exports has a Cognitive Complexity of 47 (exceeds 5 allowed). Consider refactoring.
          Open

          module.exports = function (dom, kb, subject, messageStore, options) {
  kb = kb || UI.store
  messageStore = messageStore.doc() // No hash
  var ns = UI.ns
  var WF = $rdf.Namespace('http://www.w3.org/2005/01/wf/flow#')
          Severity: Minor
          Found in src/messageArea.js - About 7 hrs to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function exports has a Cognitive Complexity of 47 (exceeds 5 allowed). Consider refactoring.
          Open

          module.exports = function (dom, kb, subject, messageStore, options) {
  kb = kb || UI.store
  messageStore = messageStore.doc() // No hash
  var ns = UI.ns
  var WF = $rdf.Namespace('http://www.w3.org/2005/01/wf/flow#')
          Severity: Minor
          Found in src/chat/thread.js - About 7 hrs to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function buildCheckboxForm has a Cognitive Complexity of 46 (exceeds 5 allowed). Consider refactoring.
          Open

          function buildCheckboxForm (dom, kb, lab, del, ins, form, store, tristate) {
  // 20190115
  var box = dom.createElement('div')
  var tx = dom.createTextNode(lab)
  var editable = UI.store.updater.editable(store.uri)
          Severity: Minor
          Found in src/widgets/forms.js - About 7 hrs to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          File peoplePicker.js has 456 lines of code (exceeds 250 allowed). Consider refactoring.
          Open

          /**
 *
 * People Picker Pane
 *
 * This pane offers a mechanism for selecting a set of individuals, groups, or
          Severity: Minor
          Found in src/widgets/peoplePicker.js - About 6 hrs to fix

            Function makeDropTarget has a Cognitive Complexity of 45 (exceeds 5 allowed). Consider refactoring.
            Open

            function makeDropTarget (ele, droppedURIHandler, droppedFileHandler) {
  var dragoverListener = function (e) {
    e.preventDefault() // Neeed else drop does not work [sic]
    e.dataTransfer.dropEffect = 'copy'
  }
            Severity: Minor
            Found in src/widgets/dragAndDrop.js - About 6 hrs to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function makeSelectForOptions has 170 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

            forms.makeSelectForOptions = function (
  dom,
  kb,
  subject,
  predicate,
            Severity: Major
            Found in src/widgets/forms.js - About 6 hrs to fix

              Function addListeners has 165 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                var addListeners = function (part, chunk) {
    part.addEventListener('keydown', function (event) {
      var queueProperty, queue
      //  up 38; down 40; left 37; right 39     tab 9; shift 16; escape 27
      switch (event.keyCode) {
              Severity: Major
              Found in src/pad.js - About 6 hrs to fix

                Function newMessageForm has 163 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                  function newMessageForm (messageTable) {
    var form = dom.createElement('tr')
    var lhs = dom.createElement('td')
    var middle = dom.createElement('td')
    var rhs = dom.createElement('td')
                Severity: Major
                Found in src/chat/infinite.js - About 6 hrs to fix

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                    private renderPersonButton (): HTMLElement {
    return widgets.button(
      this.groupList.controller.dom,
      icons.iconBase + widgets.iconForClass['vcard:Individual'],
      'Add Person',
                  Severity: Major
                  Found in src/acl/add-agent-buttons.ts and 1 other location - About 6 hrs to fix
                  src/acl/add-agent-buttons.ts on lines 73..86

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 163.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                    private renderGroupButton (): HTMLElement {
    return widgets.button(
      this.groupList.controller.dom,
      icons.iconBase + widgets.iconForClass['vcard:Group'],
      'Add Group',
                  Severity: Major
                  Found in src/acl/add-agent-buttons.ts and 1 other location - About 6 hrs to fix
                  src/acl/add-agent-buttons.ts on lines 58..71

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 163.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Function renderMessageTable has 155 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                    function renderMessageTable (date, live) {
    var scrollBackButton
    var scrollForwardButton

    /// /////////////////   Scroll down adding more above
                  Severity: Major
                  Found in src/chat/infinite.js - About 6 hrs to fix

                    Function selectWorkspace has 151 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                    export function selectWorkspace (
  dom: HTMLDocument,
  appDetails: AppDetails,
  callbackWS: (workspace: string | null, newBase: string) => void
): HTMLElement {
                    Severity: Major
                    Found in src/authn/authn.ts - About 6 hrs to fix

                      Function basicField has 134 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                      function basicField (
  dom,
  container,
  already,
  subject,
                      Severity: Major
                      Found in src/widgets/forms.js - About 5 hrs to fix

                        Function label has a Cognitive Complexity of 33 (exceeds 5 allowed). Consider refactoring.
                        Open

                        function label (x, initialCap) {
  // x is an object
  function doCap (s) {
    // s = s.toString()
    if (initialCap) return s.slice(0, 1).toUpperCase() + s.slice(1)
                        Severity: Minor
                        Found in src/utils.js - About 4 hrs to fix

                        Cognitive Complexity

                        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                        A method's cognitive complexity is based on a few simple rules:

                        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                        • Code is considered more complex for each "break in the linear flow of the code"
                        • Code is considered more complex when "flow breaking structures are nested"

                        Further reading

                        Function messageToolbar has a Cognitive Complexity of 33 (exceeds 5 allowed). Consider refactoring.
                        Open

                        export function messageToolbar (message, messageRow, userContext) {
  const div = dom.createElement('div')
  function closeToolbar () {
    div.parentElement.parentElement.removeChild(div.parentElement) // remive the TR
  }
                        Severity: Minor
                        Found in src/chat/messageTools.js - About 4 hrs to fix

                        Cognitive Complexity

                        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                        A method's cognitive complexity is based on a few simple rules:

                        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                        • Code is considered more complex for each "break in the linear flow of the code"
                        • Code is considered more complex when "flow breaking structures are nested"

                        Further reading

                        Function renderMessage has 122 lines of code (exceeds 25 allowed). Consider refactoring.
                        Open

                        export function renderMessage (
  messageTable,
  bindings,
  fresh,
  options,
                        Severity: Major
                        Found in src/chat/message.js - About 4 hrs to fix
                          Severity
                          Category
                          Status
                          Source
                          Language