Sign upLogin

michielbdejong/solid-ui

View on GitHub
Star
src/authn/authn.ts

Summary

Maintainability
F
1 wk
Test Coverage

File authn.ts has 1031 lines of code (exceeds 250 allowed). Consider refactoring.
Open

/**
 * signin.js
 *
 * Signing in, signing up, profile and preferences reloading
 * Type index management
Severity: Major
Found in src/authn/authn.ts - About 2 days to fix

    Function selectWorkspace has 151 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    export function selectWorkspace (
  dom: HTMLDocument,
  appDetails: AppDetails,
  callbackWS: (workspace: string | null, newBase: string) => void
): HTMLElement {
    Severity: Major
    Found in src/authn/authn.ts - About 6 hrs to fix

      Function displayOptions has 120 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        function displayOptions (context) {
    // const status = ''
    const id = context.me
    const preferencesFile = context.preferencesFile
    let newBase = null
      Severity: Major
      Found in src/authn/authn.ts - About 4 hrs to fix

        Function selectWorkspace has a Cognitive Complexity of 29 (exceeds 5 allowed). Consider refactoring.
        Open

        export function selectWorkspace (
  dom: HTMLDocument,
  appDetails: AppDetails,
  callbackWS: (workspace: string | null, newBase: string) => void
): HTMLElement {
        Severity: Minor
        Found in src/authn/authn.ts - About 4 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function loginStatusBox has a Cognitive Complexity of 28 (exceeds 5 allowed). Consider refactoring.
        Open

        export function loginStatusBox (
  dom: HTMLDocument,
  listener: ((uri: string | null) => void) | null = null,
  options: {
    buttonStyle?: string
        Severity: Minor
        Found in src/authn/authn.ts - About 4 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function loginStatusBox has 83 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        export function loginStatusBox (
  dom: HTMLDocument,
  listener: ((uri: string | null) => void) | null = null,
  options: {
    buttonStyle?: string
        Severity: Major
        Found in src/authn/authn.ts - About 3 hrs to fix

          Function ensureOneTypeIndex has a Cognitive Complexity of 23 (exceeds 5 allowed). Consider refactoring.
          Open

          async function ensureOneTypeIndex (context: AuthenticationContext, isPublic: boolean): Promise<AuthenticationContext | void> {
  async function makeIndexIfNecessary (context, isPublic) {
    const relevant = isPublic ? context.publicProfile : context.preferencesFile
    const visibility = isPublic ? 'public' : 'private'
          Severity: Minor
          Found in src/authn/authn.ts - About 3 hrs to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function registrationControl has 78 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

          export function registrationControl (
  context: AuthenticationContext,
  instance,
  klass
): Promise<AuthenticationContext | void> {
          Severity: Major
          Found in src/authn/authn.ts - About 3 hrs to fix

            Function logInLoadPreferences has 73 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

            export function logInLoadPreferences (context: AuthenticationContext): Promise<AuthenticationContext> {
  if (context.preferencesFile) return Promise.resolve(context) // already done

  const statusArea = context.statusArea || context.div || null
  let progressDisplay
            Severity: Major
            Found in src/authn/authn.ts - About 2 hrs to fix

              Function ensureOneTypeIndex has 61 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

              async function ensureOneTypeIndex (context: AuthenticationContext, isPublic: boolean): Promise<AuthenticationContext | void> {
  async function makeIndexIfNecessary (context, isPublic) {
    const relevant = isPublic ? context.publicProfile : context.preferencesFile
    const visibility = isPublic ? 'public' : 'private'
              Severity: Major
              Found in src/authn/authn.ts - About 2 hrs to fix

                Function signInOrSignUpBox has 50 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                function signInOrSignUpBox (
  dom: HTMLDocument,
  setUserCallback: (user: string) => void,
  options: {
    buttonStyle?: string
                Severity: Minor
                Found in src/authn/authn.ts - About 2 hrs to fix

                  Function makeIndexIfNecessary has 46 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                    async function makeIndexIfNecessary (context, isPublic) {
    const relevant = isPublic ? context.publicProfile : context.preferencesFile
    const visibility = isPublic ? 'public' : 'private'

    async function putIndex (newIndex) {
                  Severity: Minor
                  Found in src/authn/authn.ts - About 1 hr to fix

                    Function findAppInstances has 43 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                    export async function findAppInstances (
  context: AuthenticationContext,
  klass: $rdf.NamedNode,
  isPublic: boolean
): Promise<AuthenticationContext> {
                    Severity: Minor
                    Found in src/authn/authn.ts - About 1 hr to fix

                      Function registrationList has 41 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                      export function registrationList (context: AuthenticationContext, options: {
  private?: boolean
  public?: boolean
}): Promise<AuthenticationContext> {
  const dom = context.dom as HTMLDocument
                      Severity: Minor
                      Found in src/authn/authn.ts - About 1 hr to fix

                        Function loadIndex has 38 lines of code (exceeds 25 allowed). Consider refactoring.
                        Open

                        async function loadIndex (
  context: AuthenticationContext,
  predicate: $rdf.NamedNode,
  isPublic: boolean
): Promise<AuthenticationContext> {
                        Severity: Minor
                        Found in src/authn/authn.ts - About 1 hr to fix

                          Function logInLoadProfile has 33 lines of code (exceeds 25 allowed). Consider refactoring.
                          Open

                          export function logInLoadProfile (context: AuthenticationContext): Promise<AuthenticationContext> {
  if (context.publicProfile) {
    return Promise.resolve(context)
  } // already done
  const fetcher = kb.fetcher
                          Severity: Minor
                          Found in src/authn/authn.ts - About 1 hr to fix

                            Function loadIndex has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
                            Open

                            async function loadIndex (
  context: AuthenticationContext,
  predicate: $rdf.NamedNode,
  isPublic: boolean
): Promise<AuthenticationContext> {
                            Severity: Minor
                            Found in src/authn/authn.ts - About 1 hr to fix

                            Cognitive Complexity

                            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                            A method's cognitive complexity is based on a few simple rules:

                            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                            • Code is considered more complex for each "break in the linear flow of the code"
                            • Code is considered more complex when "flow breaking structures are nested"

                            Further reading

                            Function setACLUserPublic has 27 lines of code (exceeds 25 allowed). Consider refactoring.
                            Open

                            export function setACLUserPublic (
  docURI: $rdf.NamedNode,
  me: $rdf.NamedNode,
  options: {
    defaultForNew?: boolean,
                            Severity: Minor
                            Found in src/authn/authn.ts - About 1 hr to fix

                              Function findAppInstances has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                              Open

                              export async function findAppInstances (
  context: AuthenticationContext,
  klass: $rdf.NamedNode,
  isPublic: boolean
): Promise<AuthenticationContext> {
                              Severity: Minor
                              Found in src/authn/authn.ts - About 45 mins to fix

                              Cognitive Complexity

                              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                              A method's cognitive complexity is based on a few simple rules:

                              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                              • Code is considered more complex for each "break in the linear flow of the code"
                              • Code is considered more complex when "flow breaking structures are nested"

                              Further reading

                              Function offlineTestID has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                              Open

                              export function offlineTestID (): $rdf.NamedNode | null {
  const { $SolidTestEnvironment }: any = window
  if (
    typeof $SolidTestEnvironment !== 'undefined' &&
    $SolidTestEnvironment.username
                              Severity: Minor
                              Found in src/authn/authn.ts - About 35 mins to fix

                              Cognitive Complexity

                              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                              A method's cognitive complexity is based on a few simple rules:

                              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                              • Code is considered more complex for each "break in the linear flow of the code"
                              • Code is considered more complex when "flow breaking structures are nested"

                              Further reading

                              Avoid too many return statements within this function.
                              Open

                                return null
                              Severity: Major
                              Found in src/authn/authn.ts - About 30 mins to fix

                                Similar blocks of code found in 2 locations. Consider refactoring.
                                Open

                                      if (context.index && context.index.public && context.index.public.length > 0) {
        index = context.index.public[0]
        statements = registrationStatements(index)
        tbody.children[0].appendChild(
          widgets.buildCheckboxForm(
                                Severity: Major
                                Found in src/authn/authn.ts and 1 other location - About 4 hrs to fix
                                src/authn/authn.ts on lines 617..631

                                Duplicated Code

                                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                Tuning

                                This issue has a mass of 123.

                                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                Refactorings

                                Further Reading

                                Similar blocks of code found in 2 locations. Consider refactoring.
                                Open

                                      if (context.index && context.index.private && context.index.private.length > 0) {
        index = context.index.private[0]
        statements = registrationStatements(index)
        tbody.children[1].appendChild(
          widgets.buildCheckboxForm(
                                Severity: Major
                                Found in src/authn/authn.ts and 1 other location - About 4 hrs to fix
                                src/authn/authn.ts on lines 601..615

                                Duplicated Code

                                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                Tuning

                                This issue has a mass of 123.

                                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                Refactorings

                                Further Reading

                                Similar blocks of code found in 2 locations. Consider refactoring.
                                Open

                                      try {
        await kb.fetcher.load(ixs)
      } catch (err) {
        widgets.complain(context, `ensureOneTypeIndex: loading indexes ${err}`)
      }
                                Severity: Minor
                                Found in src/authn/authn.ts and 1 other location - About 50 mins to fix
                                src/authn/authn.ts on lines 351..355

                                Duplicated Code

                                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                Tuning

                                This issue has a mass of 51.

                                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                Refactorings

                                Further Reading

                                Similar blocks of code found in 2 locations. Consider refactoring.
                                Open

                                  try {
    await kb.fetcher.load(ixs)
  } catch (err) {
    widgets.complain(context, `loadPubicIndex: loading public type index ${err}`)
  }
                                Severity: Minor
                                Found in src/authn/authn.ts and 1 other location - About 50 mins to fix
                                src/authn/authn.ts on lines 425..429

                                Duplicated Code

                                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                Tuning

                                This issue has a mass of 51.

                                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                Refactorings

                                Further Reading

                                Identical blocks of code found in 2 locations. Consider refactoring.
                                Open

                                        if (session && session.webId) {
          me = $rdf.sym(session.webId)
        } else {
          me = null
        }
                                Severity: Minor
                                Found in src/authn/authn.ts and 1 other location - About 30 mins to fix
                                src/authn/authn.ts on lines 1128..1132

                                Duplicated Code

                                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                Tuning

                                This issue has a mass of 45.

                                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                Refactorings

                                Further Reading

                                Identical blocks of code found in 2 locations. Consider refactoring.
                                Open

                                      if (session && session.webId) {
        me = $rdf.sym(session.webId)
      } else {
        me = null
      }
                                Severity: Minor
                                Found in src/authn/authn.ts and 1 other location - About 30 mins to fix
                                src/authn/authn.ts on lines 1105..1109

                                Duplicated Code

                                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                Tuning

                                This issue has a mass of 45.

                                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                Refactorings

                                Further Reading

                                There are no issues that match your filters.

                                Category
                                Status