Sign upLogin

michielbdejong/solid-ui

View on GitHub
Star
src/chat/messageTools.js

Summary

Maintainability
D
2 days
Test Coverage

Function messageToolbar has a Cognitive Complexity of 33 (exceeds 5 allowed). Consider refactoring.
Open

export function messageToolbar (message, messageRow, userContext) {
  const div = dom.createElement('div')
  function closeToolbar () {
    div.parentElement.parentElement.removeChild(div.parentElement) // remive the TR
  }
Severity: Minor
Found in src/chat/messageTools.js - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function messageToolbar has 113 lines of code (exceeds 25 allowed). Consider refactoring.
Open

export function messageToolbar (message, messageRow, userContext) {
  const div = dom.createElement('div')
  function closeToolbar () {
    div.parentElement.parentElement.removeChild(div.parentElement) // remive the TR
  }
Severity: Major
Found in src/chat/messageTools.js - About 4 hrs to fix

    Function sentimentButton has 52 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      function sentimentButton (
    context,
    target,
    icon,
    actionClass,
    Severity: Major
    Found in src/chat/messageTools.js - About 2 hrs to fix

      Function button has 27 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

            async function (_event) {
        if (action) {
          await deleteThingThen(action)
          action = null
          setColor()
      Severity: Minor
      Found in src/chat/messageTools.js - About 1 hr to fix

        Function sentimentButton has 6 arguments (exceeds 4 allowed). Consider refactoring.
        Open

            context,
    target,
    icon,
    actionClass,
    doc,
        Severity: Minor
        Found in src/chat/messageTools.js - About 45 mins to fix

          Identical blocks of code found in 3 locations. Consider refactoring.
          Open

          const UI = {
  authn: require('../authn/authn'),
  icons: require('../iconBase'),
  log: require('../log'),
  ns: require('../ns'),
          Severity: Major
          Found in src/chat/messageTools.js and 2 other locations - About 3 hrs to fix
          src/chat/bookmarks.js on lines 3..15
          src/chat/message.js on lines 4..16

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 106.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

          function updatePromise (del, ins) {
  return new Promise(function (resolve, reject) {
    kb.updater.update(del, ins, function (uri, ok, errorBody) {
      if (!ok) {
        reject(new Error(errorBody))
          Severity: Major
          Found in src/chat/messageTools.js and 1 other location - About 2 hrs to fix
          src/chat/bookmarks.js on lines 74..84

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 77.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status