Sign upLogin

michielbdejong/solid-ui

View on GitHub
Star
src/messageArea.js

Summary

Maintainability
F
3 wks
Test Coverage

Function exports has 307 lines of code (exceeds 25 allowed). Consider refactoring.
Open

module.exports = function (dom, kb, subject, messageStore, options) {
  kb = kb || UI.store
  messageStore = messageStore.doc() // No hash
  var ns = UI.ns
  var WF = $rdf.Namespace('http://www.w3.org/2005/01/wf/flow#')
Severity: Major
Found in src/messageArea.js - About 1 day to fix

    Function exports has a Cognitive Complexity of 47 (exceeds 5 allowed). Consider refactoring.
    Open

    module.exports = function (dom, kb, subject, messageStore, options) {
  kb = kb || UI.store
  messageStore = messageStore.doc() // No hash
  var ns = UI.ns
  var WF = $rdf.Namespace('http://www.w3.org/2005/01/wf/flow#')
    Severity: Minor
    Found in src/messageArea.js - About 7 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    File messageArea.js has 321 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    /* global $rdf */
//  Common code for a discussion are a of messages about something
//
var UI = {
  authn: require('./authn/authn'),
    Severity: Minor
    Found in src/messageArea.js - About 3 hrs to fix

      Function newMessageForm has 91 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        var newMessageForm = function () {
    var form = dom.createElement('tr')
    var lhs = dom.createElement('td')
    var middle = dom.createElement('td')
    var rhs = dom.createElement('td')
      Severity: Major
      Found in src/messageArea.js - About 3 hrs to fix

        Function renderMessage has 75 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          var renderMessage = function (bindings, fresh) {
    var creator = bindings['?creator']
    var message = bindings['?msg']
    var date = bindings['?date']
    var content = bindings['?content']
        Severity: Major
        Found in src/messageArea.js - About 3 hrs to fix

          Function sendMessage has 45 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              var sendMessage = function () {
      // titlefield.setAttribute('class','pendingedit')
      // titlefield.disabled = true
      field.setAttribute('class', 'pendingedit')
      field.disabled = true
          Severity: Minor
          Found in src/messageArea.js - About 1 hr to fix

            Function turnOnInput has 26 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                var turnOnInput = function () {
      creatorAndDate(lhs, me, '', null)

      field = dom.createElement('textarea')
      middle.innerHTML = ''
            Severity: Minor
            Found in src/messageArea.js - About 1 hr to fix

              Function exports has 5 arguments (exceeds 4 allowed). Consider refactoring.
              Open

              module.exports = function (dom, kb, subject, messageStore, options) {
              Severity: Minor
              Found in src/messageArea.js - About 35 mins to fix

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                module.exports = function (dom, kb, subject, messageStore, options) {
  kb = kb || UI.store
  messageStore = messageStore.doc() // No hash
  var ns = UI.ns
  var WF = $rdf.Namespace('http://www.w3.org/2005/01/wf/flow#')
                Severity: Major
                Found in src/messageArea.js and 1 other location - About 2 wks to fix
                src/chat/thread.js on lines 20..384

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 3070.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                var UI = {
  authn: require('./authn/authn'),
  icons: require('./iconBase'),
  log: require('./log'),
  ns: require('./ns'),
                Severity: Major
                Found in src/messageArea.js and 1 other location - About 2 hrs to fix
                src/chat/thread.js on lines 4..14

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 93.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                There are no issues that match your filters.

                Category
                Status