Sign upLogin

michielbdejong/solid-ui

View on GitHub
Star
src/tabs.js

Summary

Maintainability
F
3 days
Test Coverage

Function tabWidget has a Cognitive Complexity of 67 (exceeds 5 allowed). Consider refactoring.
Open

UI.tabs.tabWidget = function (options) {
  var kb = UI.store
  var subject = options.subject
  var dom = options.dom
  var orientation = parseInt(options.orientation || '0')
Severity: Minor
Found in src/tabs.js - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function tabWidget has 234 lines of code (exceeds 25 allowed). Consider refactoring.
Open

UI.tabs.tabWidget = function (options) {
  var kb = UI.store
  var subject = options.subject
  var dom = options.dom
  var orientation = parseInt(options.orientation || '0')
Severity: Major
Found in src/tabs.js - About 1 day to fix

    Function orderedSync has 49 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      var orderedSync = function () {
    var items = getItems()
    if (!vertical) {
      // mainElement.setAttribute('colspan', items.length + (onClose ? 1 : 0))
    }
    Severity: Minor
    Found in src/tabs.js - About 1 hr to fix

      Function makeNewSlot has 36 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        var makeNewSlot = function (item) {
    var ele = dom.createElement(tabElement)
    ele.subject = item
    var div = ele.appendChild(dom.createElement('div'))
    div.setAttribute('style', unselectedStyle)
      Severity: Minor
      Found in src/tabs.js - About 1 hr to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

              } else {
        if (bodyMain.asSetttings !== false) {
          bodyMain.innerHTML = 'loading item ...' + item
          options.renderMain(bodyMain, ele.subject)
          bodyMain.asSetttings = false
        Severity: Major
        Found in src/tabs.js and 1 other location - About 1 hr to fix
        src/tabs.js on lines 172..178

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 60.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

              if (options.renderTabSettings && e.altKey) {
        if (bodyMain.asSetttings !== true) {
          bodyMain.innerHTML = 'loading settings ...' + item
          options.renderTabSettings(bodyMain, ele.subject)
          bodyMain.asSetttings = true
        Severity: Major
        Found in src/tabs.js and 1 other location - About 1 hr to fix
        src/tabs.js on lines 178..184

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 60.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status