Sign upLogin

michielbdejong/solid-ui

View on GitHub
Star
src/widgets/dragAndDrop.js

Summary

Maintainability
F
3 days
Test Coverage

Function makeDropTarget has a Cognitive Complexity of 45 (exceeds 5 allowed). Consider refactoring.
Open

function makeDropTarget (ele, droppedURIHandler, droppedFileHandler) {
  var dragoverListener = function (e) {
    e.preventDefault() // Neeed else drop does not work [sic]
    e.dataTransfer.dropEffect = 'copy'
  }
Severity: Minor
Found in src/widgets/dragAndDrop.js - About 6 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function uploadFiles has a Cognitive Complexity of 27 (exceeds 5 allowed). Consider refactoring.
Open

function uploadFiles (fetcher, files, fileBase, imageBase, successHandler) {
  for (var i = 0; files[i]; i++) {
    const f = files[i]
    console.log(
      ' dropped: Filename: ' +
Severity: Minor
Found in src/widgets/dragAndDrop.js - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function makeDropTarget has 93 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function makeDropTarget (ele, droppedURIHandler, droppedFileHandler) {
  var dragoverListener = function (e) {
    e.preventDefault() // Neeed else drop does not work [sic]
    e.dataTransfer.dropEffect = 'copy'
  }
Severity: Major
Found in src/widgets/dragAndDrop.js - About 3 hrs to fix

    Function uploadFiles has 65 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    function uploadFiles (fetcher, files, fileBase, imageBase, successHandler) {
  for (var i = 0; files[i]; i++) {
    const f = files[i]
    console.log(
      ' dropped: Filename: ' +
    Severity: Major
    Found in src/widgets/dragAndDrop.js - About 2 hrs to fix

      Function dropListener has 50 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        var dropListener = function (e) {
    if (e.preventDefault) e.preventDefault() // stops the browser from redirecting off to the text.
    console.log('Drop event. dropEffect: ' + e.dataTransfer.dropEffect)
    console.log(
      'Drop event. types: ' +
      Severity: Minor
      Found in src/widgets/dragAndDrop.js - About 2 hrs to fix

        Function onload has 48 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            reader.onload = (function (theFile) {
      return function (e) {
        var data = e.target.result
        var suffix = ''
        console.log(' File read byteLength : ' + data.byteLength)
        Severity: Minor
        Found in src/widgets/dragAndDrop.js - About 1 hr to fix

          Function makeDraggable has 31 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

          function makeDraggable (tr, obj) {
  tr.setAttribute('draggable', 'true') // Stop the image being dragged instead - just the TR

  tr.addEventListener(
    'dragstart',
          Severity: Minor
          Found in src/widgets/dragAndDrop.js - About 1 hr to fix

            Function uploadFiles has 5 arguments (exceeds 4 allowed). Consider refactoring.
            Open

            function uploadFiles (fetcher, files, fileBase, imageBase, successHandler) {
            Severity: Minor
            Found in src/widgets/dragAndDrop.js - About 35 mins to fix

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                          console.log(
              'Filename: ' +
                f.name +
                ', type: ' +
                (f.type || 'n/a') +
              Severity: Major
              Found in src/widgets/dragAndDrop.js and 1 other location - About 2 hrs to fix
              src/widgets/dragAndDrop.js on lines 173..182

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 75.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                  console.log(
      ' dropped: Filename: ' +
        f.name +
        ', type: ' +
        (f.type || 'n/a') +
              Severity: Major
              Found in src/widgets/dragAndDrop.js and 1 other location - About 2 hrs to fix
              src/widgets/dragAndDrop.js on lines 71..82

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 75.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status