micro-toolkit/zmq-service-suite-client-js

View on GitHub

Showing 4 of 4 total issues

Function exports has 106 lines of code (exceeds 25 allowed). Consider refactoring.
Open

module.exports = function(grunt) {

  grunt.initConfig({
    pkg: grunt.file.readJSON('package.json'),

Severity: Major
Found in Gruntfile.js - About 4 hrs to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

      log.info(message, "REP to %s:%s#%s with id %s ended with timeout after %s ms!",
        message.address.sid, message.address.sversion, message.address.verb, message.rid,
        options.timeout);
    Severity: Minor
    Found in client.js and 1 other location - About 40 mins to fix
    client.js on lines 84..86

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 49.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        log.warn(message, "Detected uncleared timeout for ended request %s:%s#%s with id %s after %s ms!",
          message.address.sid, message.address.sversion, message.address.verb, message.rid,
          options.timeout);
    Severity: Minor
    Found in client.js and 1 other location - About 40 mins to fix
    client.js on lines 97..99

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 49.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Function sendMessage has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

    function sendMessage(socket, dfd, verb, payload, options){
    Severity: Minor
    Found in client.js - About 35 mins to fix
      Severity
      Category
      Status
      Source
      Language