mike-north/ember-orientation

View on GitHub

Showing 3 of 12 total issues

Function exports has 78 lines of code (exceeds 25 allowed). Consider refactoring.
Open

module.exports = function() {
  return Promise.all([
    getChannelURL('release'),
    getChannelURL('beta'),
    getChannelURL('canary')
Severity: Major
Found in config/ember-try.js - About 3 hrs to fix

    Function init has 50 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      init() {
        this._super(...arguments);
        this.set('_tilt', {
          alpha: null,
          beta: null,
    Severity: Minor
    Found in addon/services/device-orientation.js - About 2 hrs to fix

      Function init has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

        init() {
          this._super(...arguments);
          this.set('_tilt', {
            alpha: null,
            beta: null,
      Severity: Minor
      Found in addon/services/device-orientation.js - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Severity
      Category
      Status
      Source
      Language