Sign upLogin

minad/mimemagic

View on GitHub
Star

Showing 5 of 7 total issues

Method parse_database has 71 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def self.parse_database
    file = open_mime_database

    doc = Nokogiri::XML(file)
    extensions = {}
Severity: Major
Found in lib/mimemagic/tables.rb - About 2 hrs to fix

    Method get_matches has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
    Open

      def self.get_matches(parent)
    parent.elements.map {|match|
      if match['mask']
        nil
      else
    Severity: Minor
    Found in lib/mimemagic/tables.rb - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method get_matches has 43 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def self.get_matches(parent)
    parent.elements.map {|match|
      if match['mask']
        nil
      else
    Severity: Minor
    Found in lib/mimemagic/tables.rb - About 1 hr to fix

      Method parse_database has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
      Open

        def self.parse_database
    file = open_mime_database

    doc = Nokogiri::XML(file)
    extensions = {}
      Severity: Minor
      Found in lib/mimemagic/tables.rb - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method magic_match_io has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

        def self.magic_match_io(io, matches, buffer)
    matches.any? do |offset, value, children|
      match =
        if Range === offset
          io.read(offset.begin, buffer)
      Severity: Minor
      Found in lib/mimemagic.rb - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Severity
      Category
      Status
      Source
      Language