lib/unit/class.rb

Summary

Maintainability
D
1 day
Test Coverage

Class Unit has 38 methods (exceeds 20 allowed). Consider refactoring.
Open

class Unit < Numeric
  attr_reader :value, :normalized, :unit, :system

  class IncompatibleUnitError < TypeError; end

Severity: Minor
Found in lib/unit/class.rb - About 5 hrs to fix

    Method reduce! has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
    Open

      def reduce!
        # Remove numbers from units
        numbers = @unit.select {|factor, unit, exp| Numeric === unit }
        @unit -= numbers
        numbers.each do |factor, number, exp|
    Severity: Minor
    Found in lib/unit/class.rb - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    File class.rb has 274 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    class Unit < Numeric
      attr_reader :value, :normalized, :unit, :system
    
      class IncompatibleUnitError < TypeError; end
    
    
    Severity: Minor
    Found in lib/unit/class.rb - About 2 hrs to fix

      Method reduce! has 38 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        def reduce!
          # Remove numbers from units
          numbers = @unit.select {|factor, unit, exp| Numeric === unit }
          @unit -= numbers
          numbers.each do |factor, number, exp|
      Severity: Minor
      Found in lib/unit/class.rb - About 1 hr to fix

        Method / has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
        Open

          def /(other)
            if Numeric === other
              other = coerce_numeric(other)
              result = if Integer === value && Integer === other.value
                         other.value == 1 ? value : Rational(value, other.value)
        Severity: Minor
        Found in lib/unit/class.rb - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method normalize! has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
        Open

          def normalize!
            if @normalized != self
              begin
                last_unit = @unit
                @unit = []
        Severity: Minor
        Found in lib/unit/class.rb - About 45 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

          def +(other)
            if Numeric === other
              other = coerce_numeric_compatible(other)
              a, b = self.normalize, other.normalize
              Unit.new(a.value + b.value, b.unit, system).in(self)
        Severity: Minor
        Found in lib/unit/class.rb and 1 other location - About 35 mins to fix
        lib/unit/class.rb on lines 86..92

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 34.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

          def -(other)
            if Numeric === other
              other = coerce_numeric_compatible(other)
              a, b = self.normalize, other.normalize
              Unit.new(a.value - b.value, b.unit, system).in(self)
        Severity: Minor
        Found in lib/unit/class.rb and 1 other location - About 35 mins to fix
        lib/unit/class.rb on lines 71..77

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 34.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status