minetro/mobilni-platby

View on GitHub

Showing 5 of 7 total issues

Method setMessage has 34 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    protected function setMessage(string $message): void
    {
        switch ($message) {
            case self::MESSAGE_CUSTOMER_BLOCKED:
                $this->message = self::MESSAGE_CUSTOMER_BLOCKED;
Severity: Minor
Found in src/Request/ConfirmRequest.php - About 1 hr to fix

    Function setMessage has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
    Open

        protected function setMessage(string $message): void
        {
            switch ($message) {
                case self::MESSAGE_CUSTOMER_BLOCKED:
                    $this->message = self::MESSAGE_CUSTOMER_BLOCKED;
    Severity: Minor
    Found in src/Request/ConfirmRequest.php - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method __construct has 8 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        public function __construct(int $id, string $phone, string $shortcode, string $text, int $timestamp, string $operator, string $country, int $att)
    Severity: Major
    Found in src/Request/SmsRequest.php - About 1 hr to fix

      Method __construct has 6 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          public function __construct(int $id, int $request, string $message, string $status, int $timestamp, int $att)
      Severity: Minor
      Found in src/Request/ConfirmRequest.php - About 45 mins to fix

        Function setStatus has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

            protected function setStatus(string $status): void
            {
                switch ($status) {
                    case self::STATUS_DELIVERED:
                        $this->status = self::STATUS_DELIVERED;
        Severity: Minor
        Found in src/Request/ConfirmRequest.php - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Severity
        Category
        Status
        Source
        Language