mipearson/gofer

View on GitHub

Showing 4 of 4 total issues

Method ssh_execute has a Cognitive Complexity of 23 (exceeds 5 allowed). Consider refactoring.
Open

    def ssh_execute(ssh, command, opts={})
      stdout, stderr, output = '', '', ''
      exit_code = 0
      ssh.open_channel do |channel|

Severity: Minor
Found in lib/gofer/ssh_wrapper.rb - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method ssh_execute has 30 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    def ssh_execute(ssh, command, opts={})
      stdout, stderr, output = '', '', ''
      exit_code = 0
      ssh.open_channel do |channel|

Severity: Minor
Found in lib/gofer/ssh_wrapper.rb - About 1 hr to fix

    Method threaded has 29 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        def threaded(meth, *args)
          _in = run_queue
          length = _in.length
          _out = Queue.new
          results = {}
    Severity: Minor
    Found in lib/gofer/cluster.rb - About 1 hr to fix

      Method threaded has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
      Open

          def threaded(meth, *args)
            _in = run_queue
            length = _in.length
            _out = Queue.new
            results = {}
      Severity: Minor
      Found in lib/gofer/cluster.rb - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Severity
      Category
      Status
      Source
      Language