mohsen1/json-formatter

View on GitHub

Showing 8 of 8 total issues

Function jsonFormatterDirective has a Cognitive Complexity of 64 (exceeds 5 allowed). Consider refactoring.
Open

.directive('jsonFormatter', ['RecursionHelper', 'JSONFormatterConfig', function jsonFormatterDirective(RecursionHelper, JSONFormatterConfig) {
  function escapeString(str) {
    return str.replace('"', '\"');
  }

Severity: Minor
Found in src/json-formatter.js - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function jsonFormatterDirective has 135 lines of code (exceeds 25 allowed). Consider refactoring.
Open

.directive('jsonFormatter', ['RecursionHelper', 'JSONFormatterConfig', function jsonFormatterDirective(RecursionHelper, JSONFormatterConfig) {
  function escapeString(str) {
    return str.replace('"', '\"');
  }

Severity: Major
Found in src/json-formatter.js - About 5 hrs to fix

    Function link has 68 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      function link(scope) {
        scope.isArray = function () {
          return angular.isArray(scope.json);
        };
    
    
    Severity: Major
    Found in src/json-formatter.js - About 2 hrs to fix

      Function JSONFormatterConfigProvider has 30 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      .provider('JSONFormatterConfig', function JSONFormatterConfigProvider() {
      
        // Default values for hover preview config
        var hoverPreviewEnabled = false;
        var hoverPreviewArrayCount = 100;
      Severity: Minor
      Found in src/json-formatter.js - About 1 hr to fix

        Avoid too many return statements within this function.
        Open

              return results[1];
        Severity: Major
        Found in src/json-formatter.js - About 30 mins to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

            $scope.randArray1 = [null, null, null].map(function(r) {
              return {value: Math.random()};
            });
          Severity: Minor
          Found in demo/demo.js and 1 other location - About 30 mins to fix
          demo/demo.js on lines 45..47

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 45.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Avoid too many return statements within this function.
          Open

                return '';
          Severity: Major
          Found in src/json-formatter.js - About 30 mins to fix

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

              $scope.randArray2 = [null, null, null].map(function(r) {
                return {value: Math.random()};
              });
            Severity: Minor
            Found in demo/demo.js and 1 other location - About 30 mins to fix
            demo/demo.js on lines 41..43

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 45.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Severity
            Category
            Status
            Source
            Language