moleculer-go/moleculer

View on GitHub

Showing 65 of 65 total issues

Similar blocks of code found in 5 locations. Consider refactoring.
Open

func (payload JSONPayload) Int64Array() []int64 {
    if payload.IsArray() {
        source := payload.result.Array()
        array := make([]int64, len(source))
        for index, item := range source {
Severity: Major
Found in serializer/jsonSerializer.go and 4 other locations - About 30 mins to fix
serializer/jsonSerializer.go on lines 313..323
serializer/jsonSerializer.go on lines 404..414
serializer/jsonSerializer.go on lines 428..438
serializer/jsonSerializer.go on lines 474..484

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 100.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 5 locations. Consider refactoring.
Open

func (payload JSONPayload) StringArray() []string {
    if payload.IsArray() {
        source := payload.result.Array()
        array := make([]string, len(source))
        for index, item := range source {
Severity: Major
Found in serializer/jsonSerializer.go and 4 other locations - About 30 mins to fix
serializer/jsonSerializer.go on lines 392..402
serializer/jsonSerializer.go on lines 404..414
serializer/jsonSerializer.go on lines 428..438
serializer/jsonSerializer.go on lines 474..484

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 100.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 5 locations. Consider refactoring.
Open

func (payload JSONPayload) BoolArray() []bool {
    if payload.IsArray() {
        source := payload.result.Array()
        array := make([]bool, len(source))
        for index, item := range source {
Severity: Major
Found in serializer/jsonSerializer.go and 4 other locations - About 30 mins to fix
serializer/jsonSerializer.go on lines 313..323
serializer/jsonSerializer.go on lines 392..402
serializer/jsonSerializer.go on lines 404..414
serializer/jsonSerializer.go on lines 428..438

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 100.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 5 locations. Consider refactoring.
Open

func (payload JSONPayload) UintArray() []uint64 {
    if payload.IsArray() {
        source := payload.result.Array()
        array := make([]uint64, len(source))
        for index, item := range source {
Severity: Major
Found in serializer/jsonSerializer.go and 4 other locations - About 30 mins to fix
serializer/jsonSerializer.go on lines 313..323
serializer/jsonSerializer.go on lines 392..402
serializer/jsonSerializer.go on lines 428..438
serializer/jsonSerializer.go on lines 474..484

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 100.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Method AmqpTransporter.Connect has a Cognitive Complexity of 21 (exceeds 20 allowed). Consider refactoring.
Open

func (t *AmqpTransporter) Connect() chan error {
    endChan := make(chan error)

    go func() {
        t.logger.Debug("AMQP Connect() - url: ", t.opts.Url)
Severity: Minor
Found in transit/amqp/amqp.go - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Severity
Category
Status
Source
Language