moneta-rb/moneta

View on GitHub
lib/moneta/adapters/activerecord.rb

Summary

Maintainability
D
1 day
Test Coverage

Class ActiveRecord has 28 methods (exceeds 20 allowed). Consider refactoring.
Open

    class ActiveRecord
      include Defaults

      supports :create, :increment, :each_key

Severity: Minor
Found in lib/moneta/adapters/activerecord.rb - About 3 hrs to fix

    Method increment has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring.
    Open

          def increment(key, amount = 1, options = {})
            with_connection do |conn|
              begin
                conn_ins(conn, key, amount.to_s)
                amount
    Severity: Minor
    Found in lib/moneta/adapters/activerecord.rb - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method initialize has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
    Open

          def initialize(options = {})
            @key_column = options.delete(:key_column) || :k
            @value_column = options.delete(:value_column) || :v
    
            if backend = options.delete(:backend)
    Severity: Minor
    Found in lib/moneta/adapters/activerecord.rb - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    File activerecord.rb has 267 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    require 'active_record'
    require 'uri'
    
    module Moneta
      module Adapters
    Severity: Minor
    Found in lib/moneta/adapters/activerecord.rb - About 2 hrs to fix

      Method initialize has 37 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

            def initialize(options = {})
              @key_column = options.delete(:key_column) || :k
              @value_column = options.delete(:value_column) || :v
      
              if backend = options.delete(:backend)
      Severity: Minor
      Found in lib/moneta/adapters/activerecord.rb - About 1 hr to fix

        Method slice has 26 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

              def slice(*keys, lock: false, **options)
                with_connection do |conn|
                  conn.create_table(:slice_keys, temporary: true) do |t|
                    t.string :key, null: false
                  end
        Severity: Minor
        Found in lib/moneta/adapters/activerecord.rb - About 1 hr to fix

          Similar blocks of code found in 5 locations. Consider refactoring.
          Open

                def fetch_values(*keys, **options)
                  return values_at(*keys, **options) unless block_given?
                  hash = Hash[slice(*keys, **options)]
                  keys.map do |key|
                    if hash.key?(key)
          Severity: Major
          Found in lib/moneta/adapters/activerecord.rb and 4 other locations - About 30 mins to fix
          lib/moneta/adapters/cassandra.rb on lines 212..220
          lib/moneta/adapters/mongo/base.rb on lines 23..31
          lib/moneta/adapters/sequel.rb on lines 180..188
          lib/moneta/adapters/sqlite.rb on lines 123..131

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 33.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status