moneta-rb/moneta

View on GitHub
lib/moneta/adapters/sequel.rb

Summary

Maintainability
F
3 days
Test Coverage

File sequel.rb has 599 lines of code (exceeds 250 allowed). Consider refactoring.
Open

require 'sequel'

module Moneta
  module Adapters
    # Sequel backend
Severity: Major
Found in lib/moneta/adapters/sequel.rb - About 1 day to fix

    Method new has a Cognitive Complexity of 25 (exceeds 5 allowed). Consider refactoring.
    Open

          def self.new(options = {})
            extensions = options.delete(:extensions)
            connection_validation_timeout = options.delete(:connection_validation_timeout)
            optimize = options.delete(:optimize)
            backend = options.delete(:backend) ||
    Severity: Minor
    Found in lib/moneta/adapters/sequel.rb - About 3 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Class Sequel has 29 methods (exceeds 20 allowed). Consider refactoring.
    Open

        class Sequel
          include Defaults
    
          supports :create, :increment, :each_key
          attr_reader :backend, :key_column, :value_column
    Severity: Minor
    Found in lib/moneta/adapters/sequel.rb - About 3 hrs to fix

      Class PostgresHStore has 27 methods (exceeds 20 allowed). Consider refactoring.
      Open

            class PostgresHStore < Sequel
              def initialize(options)
                @row = options.delete(:hstore).to_s
                @backend.extension :pg_hstore
                ::Sequel.extension :pg_hstore_ops
      Severity: Minor
      Found in lib/moneta/adapters/sequel.rb - About 3 hrs to fix

        Method increment has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
        Open

              def increment(key, amount = 1, options = {})
                @backend.transaction do
                  if existing = @load_for_update.call(key: key)
                    existing_value = existing[value_column]
                    amount += Integer(existing_value)
        Severity: Minor
        Found in lib/moneta/adapters/sequel.rb - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method new has 36 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

              def self.new(options = {})
                extensions = options.delete(:extensions)
                connection_validation_timeout = options.delete(:connection_validation_timeout)
                optimize = options.delete(:optimize)
                backend = options.delete(:backend) ||
        Severity: Minor
        Found in lib/moneta/adapters/sequel.rb - About 1 hr to fix

          Method increment has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
          Open

                  def increment(key, amount = 1, options = {})
                    @backend.transaction do
                      # this creates a row-level lock even if there is no existing row (a
                      # "gap lock").
                      if row = @load_for_update.call(key: key)
          Severity: Minor
          Found in lib/moneta/adapters/sequel.rb - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method store has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
          Open

                def store(key, value, options = {})
                  blob_value = blob(value)
                  unless @store_update.call(key: key, value: blob_value) == 1
                    @create.call(key: key, value: blob_value)
                  end
          Severity: Minor
          Found in lib/moneta/adapters/sequel.rb - About 55 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method each_key has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

                  def each_key
                    return enum_for(:each_key) { @size.call(row: @row)[:size] } unless block_given?
          
                    ds =
                      if @each_key_server
          Severity: Minor
          Found in lib/moneta/adapters/sequel.rb - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Similar blocks of code found in 5 locations. Consider refactoring.
          Open

                def fetch_values(*keys, **options)
                  return values_at(*keys, **options) unless block_given?
                  existing = Hash[slice(*keys, **options)]
                  keys.map do |key|
                    if existing.key? key
          Severity: Major
          Found in lib/moneta/adapters/sequel.rb and 4 other locations - About 30 mins to fix
          lib/moneta/adapters/activerecord.rb on lines 239..247
          lib/moneta/adapters/cassandra.rb on lines 212..220
          lib/moneta/adapters/mongo/base.rb on lines 23..31
          lib/moneta/adapters/sqlite.rb on lines 123..131

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 33.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status