mongodb/bson-ruby

View on GitHub

Showing 36 of 36 total issues

Method parse_hash has a Cognitive Complexity of 135 (exceeds 5 allowed). Consider refactoring.
Open

    module_function def parse_hash(hash, **options)
      if hash.empty?
        return {}
      end

Severity: Minor
Found in lib/bson/ext_json.rb - About 2 days to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File bench_test.rb has 716 lines of code (exceeds 250 allowed). Consider refactoring.
Open

$:.unshift(File.join(File.dirname(__FILE__), '..', 'lib'))
require 'bson'
require 'json'
require 'stringio'
require 'test/unit'
Severity: Major
Found in perf/bench_test.rb - About 1 day to fix

    Class BenchTest has 58 methods (exceeds 20 allowed). Consider refactoring.
    Open

    class BenchTest < Test::Unit::TestCase
      RESET = 'reset'
      NON_ZERO_TIME = 0.0000000001 # 10^-10
    
      def setup
    Severity: Major
    Found in perf/bench_test.rb - About 1 day to fix

      Method parse_hash has 172 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          module_function def parse_hash(hash, **options)
            if hash.empty?
              return {}
            end
      
      
      Severity: Major
      Found in lib/bson/ext_json.rb - About 6 hrs to fix

        File ByteBuf.java has 422 lines of code (exceeds 250 allowed). Consider refactoring.
        Open

        /*
         * Copyright (C) 2015-2020 MongoDB Inc.
         *
         * Licensed under the Apache License, Version 2.0 (the "License");
         * you may not use this file except in compliance with the License.
        Severity: Minor
        Found in src/main/org/bson_ruby/ByteBuf.java - About 6 hrs to fix

          Method benchmark! has 122 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

          def benchmark!
            count = 1_000_000
            Benchmark.bm do |bench|
          
              document = BSON::Document.new(field1: 'testing', field2: 'testing')
          Severity: Major
          Found in perf/bench.rb - About 4 hrs to fix

            ByteBuf has 36 methods (exceeds 20 allowed). Consider refactoring.
            Open

            public class ByteBuf extends RubyObject {
            
              /**
               * Constant for a null byte.
               */
            Severity: Minor
            Found in src/main/org/bson_ruby/ByteBuf.java - About 4 hrs to fix

              Class ObjectId has 25 methods (exceeds 20 allowed). Consider refactoring.
              Open

                class ObjectId
                  include Comparable
                  include JSON
              
                  # A object_id is type 0x07 in the BSON spec.
              Severity: Minor
              Found in lib/bson/object_id.rb - About 2 hrs to fix

                Class Binary has 25 methods (exceeds 20 allowed). Consider refactoring.
                Open

                  class Binary
                    include JSON
                
                    # A binary is type 0x05 in the BSON spec.
                    #
                Severity: Minor
                Found in lib/bson/binary.rb - About 2 hrs to fix

                  Method initialize has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
                  Open

                      def initialize(hash_or_collection, id = nil, database = nil)
                        if hash_or_collection.is_a?(Hash)
                          hash = hash_or_collection
                  
                          unless id.nil? && database.nil?
                  Severity: Minor
                  Found in lib/bson/dbref.rb - About 2 hrs to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Method test_to_bson_object_allocation has 39 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                    def test_to_bson_object_allocation
                      count = 1_000_000
                      t = Time.now
                      expression = [
                        Array[1],
                  Severity: Minor
                  Found in perf/bench_test.rb - About 1 hr to fix

                    Method create_string has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
                    Open

                            def create_string
                              if use_scientific_notation?
                                exp_pos_sign = exponent < 0 ? '' : '+'
                                if significand.length > 1
                                  str = "#{significand[0]}.#{significand[1..-1]}E#{exp_pos_sign}#{scientific_exponent}"
                    Severity: Minor
                    Found in lib/bson/decimal128/builder.rb - About 1 hr to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Method initialize has 31 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                        def initialize(hash_or_collection, id = nil, database = nil)
                          if hash_or_collection.is_a?(Hash)
                            hash = hash_or_collection
                    
                            unless id.nil? && database.nil?
                    Severity: Minor
                    Found in lib/bson/dbref.rb - About 1 hr to fix

                      Method writeCharacters has 28 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                        private int writeCharacters(final String string) {
                          int len = string.length();
                          int total = 0;
                      
                          for (int i = 0; i < len;) {
                      Severity: Minor
                      Found in src/main/org/bson_ruby/ByteBuf.java - About 1 hr to fix

                        Method as_extended_json has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
                        Open

                            def as_extended_json(**options)
                              utc_time = utc
                              if options[:mode] == :relaxed && (1970..9999).include?(utc_time.year)
                                if utc_time.usec != 0
                                  if utc_time.respond_to?(:floor)
                        Severity: Minor
                        Found in lib/bson/time.rb - About 1 hr to fix

                        Cognitive Complexity

                        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                        A method's cognitive complexity is based on a few simple rules:

                        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                        • Code is considered more complex for each "break in the linear flow of the code"
                        • Code is considered more complex when "flow breaking structures are nested"

                        Further reading

                        Method to_special_bits has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                        Open

                                def to_special_bits
                                  high = 0
                                  if match = NAN_REGEX.match(@string)
                                    high = NAN_MASK
                                    high = high | SIGN_BIT_MASK if match[1]
                        Severity: Minor
                        Found in lib/bson/decimal128/builder.rb - About 45 mins to fix

                        Cognitive Complexity

                        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                        A method's cognitive complexity is based on a few simple rules:

                        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                        • Code is considered more complex for each "break in the linear flow of the code"
                        • Code is considered more complex when "flow breaking structures are nested"

                        Further reading

                        Similar blocks of code found in 2 locations. Consider refactoring.
                        Open

                          def test_seek
                            size = 1
                            hash = Hash[*(0..size).to_a.collect{|i| [ ('a' + i.to_s), i.to_s]}.flatten]
                            method_label_pairs = [
                                [ method(:old_hash_from_bson), 'Encode bson optimize none', RESET ],
                        Severity: Minor
                        Found in perf/bench_test.rb and 1 other location - About 45 mins to fix
                        perf/bench_test.rb on lines 447..454

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 40.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        Similar blocks of code found in 2 locations. Consider refactoring.
                        Open

                          def test_hash_string_to_bson_hint # to check overhead of hint setting and passing
                            size = 1024
                            hash = Hash[*(0..size).to_a.collect{|i| [ ('a' + i.to_s), i.to_s]}.flatten]
                            method_label_pairs = [
                                [ method(:old_hash_to_bson_no_hint), 'Hash string to_bson no hint', RESET ],
                        Severity: Minor
                        Found in perf/bench_test.rb and 1 other location - About 45 mins to fix
                        perf/bench_test.rb on lines 653..660

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 40.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        Method as_extended_json has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                        Open

                            def as_extended_json(**options)
                              if infinite? == 1
                                { '$numberDouble' => 'Infinity' }
                              elsif infinite? == -1
                                { '$numberDouble' => '-Infinity' }
                        Severity: Minor
                        Found in lib/bson/float.rb - About 45 mins to fix

                        Cognitive Complexity

                        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                        A method's cognitive complexity is based on a few simple rules:

                        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                        • Code is considered more complex for each "break in the linear flow of the code"
                        • Code is considered more complex when "flow breaking structures are nested"

                        Further reading

                        Method putCString has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                        Open

                          @JRubyMethod(name = "put_cstring")
                          public ByteBuf putCString(ThreadContext context, final IRubyObject value) throws UnsupportedEncodingException {
                        
                            if (value instanceof RubyFixnum) {
                              RubyString str = ((RubyFixnum) value).to_s();
                        Severity: Minor
                        Found in src/main/org/bson_ruby/ByteBuf.java - About 35 mins to fix

                        Cognitive Complexity

                        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                        A method's cognitive complexity is based on a few simple rules:

                        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                        • Code is considered more complex for each "break in the linear flow of the code"
                        • Code is considered more complex when "flow breaking structures are nested"

                        Further reading

                        Severity
                        Category
                        Status
                        Source
                        Language