mongodb/mongo-ruby-driver

View on GitHub

Showing 227 of 284 total issues

Method command_failed has 6 arguments (exceeds 4 allowed). Consider refactoring.
Open

      def command_failed(failure, address, operation_id, payload, message, duration)
Severity: Minor
Found in lib/mongo/monitoring/publishable.rb - About 45 mins to fix

    Method clear has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

          def clear(options = nil)
            raise_if_closed!
    
            check_invariants
    
    
    Severity: Minor
    Found in lib/mongo/server/connection_pool.rb - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method check_invariants has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

          def check_invariants
            return unless Lint.enabled?
    
            # Server summary calls pool summary which requires pool lock -> deadlock.
            # Obtain the server summary ahead of time.
    Severity: Minor
    Found in lib/mongo/server/connection_pool.rb - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method generate has 6 arguments (exceeds 4 allowed). Consider refactoring.
    Open

            def self.generate(address, operation_id, payload, message, failure, duration)
    Severity: Minor
    Found in lib/mongo/monitoring/event/command_failed.rb - About 45 mins to fix

      Method initialize has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

            def initialize(user, used_mechanism: nil, message: nil,
              server: nil
            )
              configured_bits = []
              used_bits = [
      Severity: Minor
      Found in lib/mongo/auth.rb - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method update_options has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

          def update_options(new_options)
            old_options = @options
      
            validate_new_options!(new_options).tap do |opts|
              # Our options are frozen
      Severity: Minor
      Found in lib/mongo/client.rb - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method commit_changes has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

          def commit_changes
            # The application-visible sequence of events should be as follows:
            #
            # 1. Description change for the server which we are processing;
            # 2. Topology change, if any;
      Severity: Minor
      Found in lib/mongo/cluster/sdam_flow.rb - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method process has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

          def process(result)
            unless implicit?
              set_operation_time(result)
              if cluster_time_doc = result.cluster_time
                advance_cluster_time(cluster_time_doc)
      Severity: Minor
      Found in lib/mongo/session.rb - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method retry_write_allowed? has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

          def retry_write_allowed?(session, write_concern)
            unless session && session.retry_writes?
              return false
            end
      
      
      Severity: Minor
      Found in lib/mongo/retryable.rb - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method do_aes has 6 arguments (exceeds 4 allowed). Consider refactoring.
      Open

            def do_aes(key_binary_p, iv_binary_p, input_binary_p, output_binary_p,
              response_length_p, status_p, decrypt: false)
      Severity: Minor
      Found in lib/mongo/crypt/handle.rb - About 45 mins to fix

        Method initialize has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
        Open

              def initialize(options)
                options = Options::Mapper.transform_keys_to_symbols(options)
                options = Options::Mapper.transform_values_to_strings(options).freeze
        
                if options[:w]
        Severity: Minor
        Found in lib/mongo/write_concern/base.rb - About 45 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method initialize has 6 arguments (exceeds 4 allowed). Consider refactoring.
        Open

              def initialize(host, port, host_name, timeout, family, options = {})
        Severity: Minor
        Found in lib/mongo/socket/ssl.rb - About 45 mins to fix

          Method find_command has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
          Open

                  def find_command
                    document = BSON::Document.new
                    document.store(FIND, collection)
                    document.store(FILTER, query_filter)
                    OPTION_MAPPINGS.each do |legacy, option|
          Severity: Minor
          Found in lib/mongo/protocol/query.rb - About 45 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method set_cert has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
          Open

                def set_cert(context, options)
                  # Since we clear cert_text during processing, we need to examine
                  # ssl_cert_object here to avoid considering it if we have also
                  # processed the text.
                  if options[:ssl_cert]
          Severity: Minor
          Found in lib/mongo/socket/ssl.rb - About 45 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method deserialize has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
          Open

                def self.deserialize(io, max_message_size = MAX_MESSAGE_SIZE, expected_response_to = nil)
                  length, _request_id, response_to, _op_code = deserialize_header(BSON::ByteBuffer.new(io.read(16)))
          
                  # Protection from potential DOS man-in-the-middle attacks. See
                  # DRIVERS-276.
          Severity: Minor
          Found in lib/mongo/protocol/message.rb - About 45 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method validate_address_str! has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
          Open

                def validate_address_str!(address_str)
                  case address_str
                  when /\A\[[\d:]+\](?::(\d+))?\z/
                    # ipv6 with optional port
                    if port_str = $1
          Severity: Minor
          Found in lib/mongo/address/validator.rb - About 45 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method initialize has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

              def initialize(address, cluster, monitoring, event_listeners, options = {})
          Severity: Minor
          Found in lib/mongo/server.rb - About 35 mins to fix

            Method generate has 5 arguments (exceeds 4 allowed). Consider refactoring.
            Open

                    def self.generate(address, operation_id, command_payload, reply_payload, duration)
            Severity: Minor
            Found in lib/mongo/monitoring/event/command_succeeded.rb - About 35 mins to fix

              Method initialize has 5 arguments (exceeds 4 allowed). Consider refactoring.
              Open

                    def initialize(socket, description, server, monitoring, options = {})
              Severity: Minor
              Found in lib/mongo/server/pending_connection.rb - About 35 mins to fix

                Method finalize has 5 arguments (exceeds 4 allowed). Consider refactoring.
                Open

                    def self.finalize(cursor_id, cluster, op_spec, server, session)
                Severity: Minor
                Found in lib/mongo/cursor.rb - About 35 mins to fix
                  Severity
                  Category
                  Status
                  Source
                  Language