Sign upLogin

mongodb/mongo-ruby-driver

View on GitHub
Star
lib/mongo/client_encryption.rb

Summary

Maintainability
A
1 hr
Test Coverage

Method create_encrypted_collection has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

    def create_encrypted_collection(database, coll_name, coll_opts, kms_provider, master_key)
Severity: Minor
Found in lib/mongo/client_encryption.rb - About 35 mins to fix

    Method create_data_keys has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

        def create_data_keys(encrypted_fields, kms_provider, master_key)
      encrypted_fields = encrypted_fields.dup
      # We must return the partially formed encrypted_fields hash if an error
      # occurs - https://github.com/mongodb/specifications/blob/master/source/client-side-encryption/client-side-encryption.rst#create-encrypted-collection-helper
      # Thefore, we do this in a loop instead of using #map.
    Severity: Minor
    Found in lib/mongo/client_encryption.rb - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status