mongodb/mongo-ruby-driver

View on GitHub
lib/mongo/cluster.rb

Summary

Maintainability
C
1 day
Test Coverage

Class Cluster has 27 methods (exceeds 20 allowed). Consider refactoring.
Open

  class Cluster
    extend Forwardable
    include Monitoring::Publishable
    include Event::Subscriber
    include Loggable
Severity: Minor
Found in lib/mongo/cluster.rb - About 3 hrs to fix

    Method initialize has 62 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        def initialize(seeds, monitoring, options = Options::Redacted.new)
          if options[:monitoring_io] != false && !options[:server_selection_semaphore]
            raise ArgumentError, 'Need server selection semaphore'
          end
    
    
    Severity: Major
    Found in lib/mongo/cluster.rb - About 2 hrs to fix

      File cluster.rb has 265 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

      require 'mongo/cluster/topology'
      require 'mongo/cluster/reapers/socket_reaper'
      require 'mongo/cluster/reapers/cursor_reaper'
      require 'mongo/cluster/periodic_executor'
      
      
      Severity: Minor
      Found in lib/mongo/cluster.rb - About 2 hrs to fix

        Method initialize has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
        Open

            def initialize(seeds, monitoring, options = Options::Redacted.new)
              if options[:monitoring_io] != false && !options[:server_selection_semaphore]
                raise ArgumentError, 'Need server selection semaphore'
              end
        
        
        Severity: Minor
        Found in lib/mongo/cluster.rb - About 2 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        There are no issues that match your filters.

        Category
        Status