mongodb/mongo-ruby-driver

View on GitHub
lib/mongo/cluster.rb

Summary

Maintainability
F
3 days
Test Coverage

File cluster.rb has 429 lines of code (exceeds 250 allowed). Consider refactoring.
Open

require 'mongo/cluster/topology'
require 'mongo/cluster/reapers/socket_reaper'
require 'mongo/cluster/reapers/cursor_reaper'
require 'mongo/cluster/periodic_executor'

Severity: Minor
Found in lib/mongo/cluster.rb - About 6 hrs to fix

    Class Cluster has 31 methods (exceeds 20 allowed). Consider refactoring.
    Open

      class Cluster
        extend Forwardable
        include Monitoring::Publishable
        include Event::Subscriber
        include Loggable
    Severity: Minor
    Found in lib/mongo/cluster.rb - About 3 hrs to fix

      Method initialize has 79 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          def initialize(seeds, monitoring, options = Options::Redacted.new)
            if seeds.nil?
              raise ArgumentError, 'Seeds cannot be nil'
            end
      
      
      Severity: Major
      Found in lib/mongo/cluster.rb - About 3 hrs to fix

        Method validate_session_support! has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
        Open

            def validate_session_support!
              @state_change_lock.synchronize do
                @sdam_flow_lock.synchronize do
                  if topology.data_bearing_servers?
                    unless topology.logical_session_timeout
        Severity: Minor
        Found in lib/mongo/cluster.rb - About 2 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method initialize has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
        Open

            def initialize(seeds, monitoring, options = Options::Redacted.new)
              if seeds.nil?
                raise ArgumentError, 'Seeds cannot be nil'
              end
        
        
        Severity: Minor
        Found in lib/mongo/cluster.rb - About 2 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method start_stop_srv_monitor has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
        Open

            def start_stop_srv_monitor
              # SRV URI is either always given or not for a given cluster, if one
              # wasn't given we shouldn't ever have an SRV monitor to manage.
              return unless options[:srv_uri]
        
        
        Severity: Minor
        Found in lib/mongo/cluster.rb - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method disconnect! has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
        Open

            def disconnect!
              @state_change_lock.synchronize do
                unless connecting? || connected?
                  return true
                end
        Severity: Minor
        Found in lib/mongo/cluster.rb - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method disconnect! has 31 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            def disconnect!
              @state_change_lock.synchronize do
                unless connecting? || connected?
                  return true
                end
        Severity: Minor
        Found in lib/mongo/cluster.rb - About 1 hr to fix

          Method validate_session_support! has 29 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              def validate_session_support!
                @state_change_lock.synchronize do
                  @sdam_flow_lock.synchronize do
                    if topology.data_bearing_servers?
                      unless topology.logical_session_timeout
          Severity: Minor
          Found in lib/mongo/cluster.rb - About 1 hr to fix

            Method run_sdam_flow has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
            Open

                def run_sdam_flow(previous_desc, updated_desc, options = {})
                  @sdam_flow_lock.synchronize do
                    flow = SdamFlow.new(self, previous_desc, updated_desc,
                      awaited: options[:awaited])
                    flow.server_description_changed
            Severity: Minor
            Found in lib/mongo/cluster.rb - About 55 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method set_server_list has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
            Open

                def set_server_list(server_address_strs)
                  @sdam_flow_lock.synchronize do
                    server_address_strs.each do |address_str|
                      unless servers_list.any? { |server| server.address.seed == address_str }
                        add(address_str)
            Severity: Minor
            Found in lib/mongo/cluster.rb - About 45 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method add has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
            Open

                def add(host, add_options=nil)
                  address = Address.new(host, options)
                  if !addresses.include?(address)
                    server = Server.new(address, self, @monitoring, event_listeners, options.merge(
                      monitor: false))
            Severity: Minor
            Found in lib/mongo/cluster.rb - About 35 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method remove has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
            Open

                def remove(host, disconnect: true)
                  address = Address.new(host)
                  removed_servers = []
                  @update_lock.synchronize do
                    @servers.delete_if do |server|
            Severity: Minor
            Found in lib/mongo/cluster.rb - About 35 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method scan! has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

                def scan!(sync=true)
                  if sync
                    servers_list.each do |server|
                      if server.monitor
                        server.monitor.scan!
            Severity: Minor
            Found in lib/mongo/cluster.rb - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            There are no issues that match your filters.

            Category
            Status