mongodb/mongo-ruby-driver

View on GitHub
lib/mongo/protocol/message.rb

Summary

Maintainability
B
6 hrs
Test Coverage

Class Message has 24 methods (exceeds 20 allowed). Consider refactoring.
Open

    class Message
      include Id
      include Serializers

      # The batch size constant.
Severity: Minor
Found in lib/mongo/protocol/message.rb - About 2 hrs to fix

    Method deserialize has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
    Open

          def self.deserialize(io,
            max_message_size = MAX_MESSAGE_SIZE,
            expected_response_to = nil,
            options = {}
          )
    Severity: Minor
    Found in lib/mongo/protocol/message.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method deserialize has 35 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

          def self.deserialize(io,
            max_message_size = MAX_MESSAGE_SIZE,
            expected_response_to = nil,
            options = {}
          )
    Severity: Minor
    Found in lib/mongo/protocol/message.rb - About 1 hr to fix

      Method serialize_fields has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
      Open

            def serialize_fields(buffer, max_bson_size = nil)
              fields.each do |field|
                value = instance_variable_get(field[:name])
                if field[:multi]
                  value.each do |item|
      Severity: Minor
      Found in lib/mongo/protocol/message.rb - About 55 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status